Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Nov 2019 17:34:24 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Andi Kleen <andi@firstfloor.org>
Cc:     acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v4 7/9] perf stat: Use affinity for opening events
Message-ID: <20191106163424.GP30214@krava>
References: <20191105002522.83803-1-andi@firstfloor.org>
 <20191105002522.83803-8-andi@firstfloor.org>
MIME-Version: 1.0
In-Reply-To: <20191105002522.83803-8-andi@firstfloor.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 04, 2019 at 04:25:20PM -0800, Andi Kleen wrote:

SNIP

> +}
> +
>  void evsel__close(struct evsel *evsel)
>  {
>  =09perf_evsel__close(&evsel->core);
> @@ -1832,9 +1839,10 @@ void evsel__close(struct evsel *evsel)
>  }
> =20
>  int perf_evsel__open_per_cpu(struct evsel *evsel,
> -=09=09=09     struct perf_cpu_map *cpus)
> +=09=09=09     struct perf_cpu_map *cpus,
> +=09=09=09     int cpu)
>  {
> -=09return evsel__open(evsel, cpus, NULL);
> +=09return evsel__open_cpu(evsel, cpus, NULL, cpu, cpu + 1);
>  }
> =20
>  int perf_evsel__open_per_thread(struct evsel *evsel,
> diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
> index 2e3b011ed09e..d5440a928745 100644
> --- a/tools/perf/util/evsel.h
> +++ b/tools/perf/util/evsel.h
> @@ -94,6 +94,8 @@ struct evsel {
>  =09struct evsel=09=09*metric_leader;
>  =09bool=09=09=09collect_stat;
>  =09bool=09=09=09weak_group;
> +=09bool=09=09=09reset_group;
> +=09bool=09=09=09errored;

would be great to move some of the changes into separate patches,
it seems all related to new code, but would ease up the review
like these 2 bools above or adding cpu to create_perf_stat_counter
and adding evsel__open_cpu funtion and related changes

thanks,
jirka