Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Nov 2019 17:33:57 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Andi Kleen <andi@firstfloor.org>
Cc:     acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v4 6/9] perf stat: Factor out open error handling
Message-ID: <20191106163357.GM30214@krava>
References: <20191105002522.83803-1-andi@firstfloor.org>
 <20191105002522.83803-7-andi@firstfloor.org>
MIME-Version: 1.0
In-Reply-To: <20191105002522.83803-7-andi@firstfloor.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 04, 2019 at 04:25:19PM -0800, Andi Kleen wrote:

SNIP

>  =09=09=09=09goto try_again;
>  =09=09=09}
> =20
> -=09=09=09/*
> -=09=09=09 * PPC returns ENXIO for HW counters until 2.6.37
> -=09=09=09 * (behavior changed with commit b0a873e).
> -=09=09=09 */
> -=09=09=09if (errno =3D=3D EINVAL || errno =3D=3D ENOSYS ||
> -=09=09=09    errno =3D=3D ENOENT || errno =3D=3D EOPNOTSUPP ||
> -=09=09=09    errno =3D=3D ENXIO) {
> -=09=09=09=09if (verbose > 0)
> -=09=09=09=09=09ui__warning("%s event is not supported by the kernel.\n",
> -=09=09=09=09=09=09    perf_evsel__name(counter));
> -=09=09=09=09counter->supported =3D false;
> -
> -=09=09=09=09if ((counter->leader !=3D counter) ||
> -=09=09=09=09    !(counter->leader->core.nr_members > 1))
> -=09=09=09=09=09continue;
> -=09=09=09} else if (perf_evsel__fallback(counter, errno, msg, sizeof(msg=
))) {
> -                                if (verbose > 0)
> -                                        ui__warning("%s\n", msg);
> -                                goto try_again;
> -=09=09=09} else if (target__has_per_thread(&target) &&
> -=09=09=09=09   evsel_list->core.threads &&
> -=09=09=09=09   evsel_list->core.threads->err_thread !=3D -1) {
> -=09=09=09=09/*
> -=09=09=09=09 * For global --per-thread case, skip current
> -=09=09=09=09 * error thread.
> -=09=09=09=09 */
> -=09=09=09=09if (!thread_map__remove(evsel_list->core.threads,
> -=09=09=09=09=09=09=09evsel_list->core.threads->err_thread)) {
> -=09=09=09=09=09evsel_list->core.threads->err_thread =3D -1;
> -=09=09=09=09=09goto try_again;
> -=09=09=09=09}
> +=09=09=09switch (stat_handle_error(counter)) {
> +=09=09=09case COUNTER_FATAL:
> +=09=09=09=09return -1;
> +=09=09=09case COUNTER_RETRY:
> +=09=09=09=09goto try_again;
> +=09=09=09case COUNTER_SKIP:
> +=09=09=09=09continue;
> +=09=09=09default:
> +=09=09=09=09break;
>  =09=09=09}

great, looks good, thanks

jirka

> -
> -=09=09=09perf_evsel__open_strerror(counter, &target,
> -=09=09=09=09=09=09  errno, msg, sizeof(msg));
> -=09=09=09ui__error("%s\n", msg);
> -
> -=09=09=09if (child_pid !=3D -1)
> -=09=09=09=09kill(child_pid, SIGTERM);
> -
> -=09=09=09return -1;
>  =09=09}
>  =09=09counter->supported =3D true;
> =20
> --=20
> 2.23.0
>=20