Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5dc2f71e.1c69fb81.8912a.f2c0@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <c4cee81775c6d82024ca05250290f603@codeaurora.org>
References: <1572931309-16250-1-git-send-email-kgunda@codeaurora.org> <5dc1cb4c.1c69fb81.af253.0b8a@mx.google.com> <c4cee81775c6d82024ca05250290f603@codeaurora.org>
Subject: Re: [PATCH V2] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
From:   Stephen Boyd <swboyd@chromium.org>
To:     kgunda@codeaurora.org
Cc:     Andy Gross <agross@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
        lee.jones@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        rnayak@codeaurora.org
User-Agent: alot/0.8.1
Date:   Wed, 06 Nov 2019 08:38:53 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting kgunda@codeaurora.org (2019-11-05 22:43:59)
> On 2019-11-06 00:49, Stephen Boyd wrote:
> > Quoting Kiran Gunda (2019-11-04 21:21:49)
> >> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
> >> found on SC7180 based platforms.
> >>=20
> >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> >> ---
> >>  - Changes from V1:
> >>    Sorted the macros and compatibles.
> >=20
> > I don't see anything sorted though.
> >=20
> Sorry .. I might have misunderstood your comment. Let me know if my=20
> understanding is correct.
>=20
> >>>> And compatible here.
> >>> And on macro name here.
>=20
> This means you want to sort all the existing compatible and macros in=20
> alpha numeric order ?

Sorry I also got confused on what the driver is doing. I replied on the
original patch with what is preferred.