Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191106030542.868541-1-dima@arista.com> <20191106030542.868541-44-dima@arista.com>
 <CAMo8Bf+q0j81VZeUQdvCkXt131uzSBfJ0N7RTe7+NpjRkVpzdA@mail.gmail.com> <20191106081541.soxefwyvu3o72tqg@pathway.suse.cz>
In-Reply-To: <20191106081541.soxefwyvu3o72tqg@pathway.suse.cz>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Wed, 6 Nov 2019 08:44:19 -0800
Message-ID: <CAMo8Bf+ASTba15G7xj=zLTnnCaU=SeHiEO6Ab-0MCcJMiOXNkw@mail.gmail.com>
Subject: Re: [PATCH 43/50] xtensa: Add show_stack_loglvl()
To:     Petr Mladek <pmladek@suse.com>
Cc:     Dmitry Safonov <dima@arista.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Dmitry Safonov <0x7f454c46@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jslaby@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Chris Zankel <chris@zankel.net>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@linux-xtensa.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 6, 2019 at 12:15 AM Petr Mladek <pmladek@suse.com> wrote:
> > >         for (i = 0; i < kstack_depth_to_print; i++) {
> > >                 if (kstack_end(sp))
> > >                         break;
> > > -               pr_cont(" %08lx", *sp++);
> > > +               printk("%s %08lx", loglvl, *sp++);
>
> KERN_CONT can be combined with any other loglevel.
> So you could keep using pr_cont() together with explicit loglevel:
>
>                         pr_cont("%s %08lx", loglvl, *sp++);
>
> It should fix the problems reported below.
>
> Well, the preferred solution would be to snprintf() the continuous
> line into a temporary buffer. And printk() it when it is complete.
> pr_cont() is not reliable when more CPUs print at the same time.

Good point. Let me do this cleanup.

-- 
Thanks.
-- Max