Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Nov 2019 09:46:02 -0800
From:   Daniel Walker <danielwa@cisco.com>
To:     Claudiu Manoil <claudiu.manoil@nxp.com>
Cc:     Sathish Jarugumalli <sjarugum@cisco.com>,
        "xe-linux-external@cisco.com" <xe-linux-external@cisco.com>,
        Daniel Walker <dwalker@fifo99.com>,
        "David S. Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: net: gianfar: Shortest frame drops at Ethernet
 port
Message-ID: <20191106174602.GV18744@zorba>
References: <20191106170320.27662-1-danielwa@cisco.com>
 <VI1PR04MB4880B060847C1CD175B998DF96790@VI1PR04MB4880.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR04MB4880B060847C1CD175B998DF96790@VI1PR04MB4880.eurprd04.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 06, 2019 at 05:38:06PM +0000, Claudiu Manoil wrote:
> >-----Original Message-----
> >From: Daniel Walker <danielwa@cisco.com>
> >Sent: Wednesday, November 6, 2019 7:03 PM
> >To: Claudiu Manoil <claudiu.manoil@nxp.com>
> >Cc: Sathish Jarugumalli <sjarugum@cisco.com>; xe-linux-external@cisco.com;
> >Daniel Walker <dwalker@fifo99.com>; David S. Miller
> ><davem@davemloft.net>; netdev@vger.kernel.org; linux-
> >kernel@vger.kernel.org
> >Subject: [PATCH] drivers: net: gianfar: Shortest frame drops at Ethernet port
> >
> >NXP has provided the patch for packet drops  at ethernet port
> >Frames shorter than 60bytes are getting dropped at ethernetport
> >need to add padding for the shorter range frames to be transmit
> >the function "eth_skb_pad(skb" provides padding (and CRC) for
> >packets under 60 bytes
> >
> >Signed-off-by: Sathish Jarugumalli <sjarugum@cisco.com>
> >Cc: xe-linux-external@cisco.com
> >Signed-off-by: Daniel Walker <dwalker@fifo99.com>
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
> 
> Normally padding is done by the hardware, and it works at least on my
> test cases and boards.
> But cisco seems to have hit a case where h/w padding gets
> unexpectedly disabled (concurrency issue writing the config register?).
> This patch should go as a workaround, until root cause found.


Where would this hardware setup normally happen? Does it happen in the
bootloader or inside the kernel someplace ?

Daniel