Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Fail (protection.outlook.com: domain of arm.com does not
 designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   Mihail Atanassov <Mihail.Atanassov@arm.com>
To:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
CC:     nd <nd@arm.com>,
        "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>,
        Markus Elfring <Markus.Elfring@web.de>,
        David Airlie <airlied@linux.ie>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, nd <nd@arm.com>
Subject: Re: drm/komeda: Use devm_platform_ioremap_resource() in
 komeda_dev_create()
Thread-Topic: drm/komeda: Use devm_platform_ioremap_resource() in
 komeda_dev_create()
Thread-Index: AQHVfn+X0ywwD9NhU0O9ZT09tcfr2Kd+kFmA
Date:   Wed, 6 Nov 2019 17:51:43 +0000
Message-ID: <28103957.GdvMQdgHhr@e123338-lin>
References: <64a6ea39-3e4b-2ebe-74f7-98720e581e3e@web.de>
 <20191009085704.GA26615@jamwan02-TSP300>
In-Reply-To: <20191009085704.GA26615@jamwan02-TSP300>
Accept-Language: en-GB, en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Mihail.Atanassov@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 71738190-8277-449b-1792-08d762e2021b
X-MS-TrafficTypeDiagnostic: VI1PR08MB5533:|VI1PR08MB5533:|HE1PR0801MB1818:
X-MS-Exchange-PUrlCount: 1
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <HE1PR0801MB18187FC1CE07025066AE4E818F790@HE1PR0801MB1818.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691;
x-forefront-prvs: 02135EB356
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(7916004)(4636009)(346002)(396003)(366004)(39860400002)(376002)(136003)(199004)(189003)(386003)(64756008)(66556008)(66446008)(6506007)(66946007)(102836004)(5660300002)(66476007)(305945005)(71190400001)(81156014)(6486002)(86362001)(76176011)(486006)(33716001)(52116002)(6436002)(81166006)(8676002)(446003)(71200400001)(476003)(11346002)(9686003)(6246003)(6512007)(2351001)(5640700003)(2501003)(26005)(25786009)(186003)(8936002)(4326008)(6306002)(6116002)(3846002)(478600001)(229853002)(7736002)(99286004)(14454004)(966005)(256004)(316002)(2906002)(54906003)(14444005)(66066001)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB5533;H:VI1PR08MB4078.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: vXwzzM7EYQuQCoBmEwIo/DQLZq5WQWtOTUh6D6K+VKR0XKJMYIxbX3xRG0ES4yMmD3wsW6Blg/QBLYhN2+Ge4ZnnzCKtrnpSEnGSIflQryyc7Tu8xF2xNxODPGPerzQR9G/Y8g2De9TRL1Y78hhG9A1Hj0QvCk7WZrgmvVnZawpwC7fgpMW22nrzCtVzoqTiHiKqZSLpAQRxHE4+Pk2rTER2QSIb/lV9B99jA5w7NFhGO3kiv4GyHy1p8rnN7cdZcpHGVZAKqZDHdSccaHwJRUu+JXdAxyvlCjaIiDV8ompDg8knYTioOExpW5F6hPf+nwBl5wNw6oZTvP/nZlU7Hb/iO3zkSEjHLepaDjE5s8X19HhibemWMNC/pdINCCNdX55wUZBm16ELYVujmjVKXSMympht9eAtrHzW5/s7xOlrWFI9oHJBOisx2EZ767tF3Zps8tjn152Fw5hpm6Xl9ADZegKDgYlDDPBxxctsleI=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <184B2102DD5CE648896FEEA08791FEB1@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5533
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Mihail.Atanassov@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(4636009)(136003)(396003)(346002)(376002)(39860400002)(1110001)(339900001)(199004)(189003)(54906003)(5640700003)(86362001)(22756006)(66066001)(8746002)(450100002)(2906002)(305945005)(81166006)(81156014)(70586007)(478600001)(966005)(26826003)(7736002)(99286004)(36906005)(316002)(25786009)(26005)(2501003)(47776003)(2351001)(3846002)(6116002)(105606002)(356004)(76130400001)(50466002)(23726003)(102836004)(6506007)(386003)(14454004)(70206006)(8676002)(8936002)(46406003)(6512007)(33716001)(11346002)(9686003)(6306002)(126002)(486006)(446003)(476003)(4326008)(14444005)(186003)(336012)(6862004)(6486002)(5660300002)(229853002)(76176011)(97756001)(6246003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0801MB1818;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Fail;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: af046850-12c4-428a-10f7-08d762e1fc27
NoDisclaimer: True
X-Forefront-PRVS: 02135EB356
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rBLvvWXGtHkbFtxpkIdtoJGC/HS1GpWzjh+ybSr4ucsMcUJr8K6oT/rgg3glB/233b3YyXLbmbhj4YYFqTGOgDhvf9x7Ye597iXRrgiMHmxMxxwi9GQzyKd2jcmYMxUMp9V6zJVVWmT3HKC8SVDybzFWsa1TT5CGK5oZLp2F5XR+w9puTrVXtZAn6N+akMcstz276mvKf96btDMwzl55Kr5dxVam0ARyDKPfYVWaiY0cV6mfSxWYI4Eyautix/oXXTSZRVMWtY4QStEj55cq35INL05E7qyMhyMxpRdWkFfVuJ/2PMTqh7sMGKQlpdLnfyHNxSySkxyzKIRtXDl8MuBOMRslWqFdVd2CsPn6rDL4QK62lCkiUalisnewcuxFAOVhXaaxqvY6DrBgBobmFipNRJwLfhq07HdDooda2wAYqYznvFqXjGcKYefzKwX35KeuWzIxtbLmEhaLOxC6F+9vQO6IEKx/0SMAsNlul8M=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2019 17:51:53.2844
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 71738190-8277-449b-1792-08d762e2021b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1818
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, 9 October 2019 09:57:11 GMT james qian wang (Arm Technology C=
hina) wrote:
> On Sat, Sep 21, 2019 at 07:50:46PM +0200, Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sat, 21 Sep 2019 19:43:51 +0200
> >=20
> > Simplify this function implementation by using a known wrapper function=
.
> >=20
> > This issue was detected by using the Coccinelle software.
> >=20
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>=20
> Thank you for the patch.
>=20
> Looks good to me.
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.=
com>

Applied to drm-misc-next - 50ec5b563bed04b0b262822b755f6aa336f1f40a

>=20
> > ---
> >  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >=20
> > --
> > 2.23.0
> >=20
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/=
gpu/drm/arm/display/komeda/komeda_dev.c
> > index ca64a129c594..a387d923962e 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -172,19 +172,12 @@ struct komeda_dev *komeda_dev_create(struct devic=
e *dev)
> >  	struct platform_device *pdev =3D to_platform_device(dev);
> >  	const struct komeda_product_data *product;
> >  	struct komeda_dev *mdev;
> > -	struct resource *io_res;
> >  	int err =3D 0;
> >=20
> >  	product =3D of_device_get_match_data(dev);
> >  	if (!product)
> >  		return ERR_PTR(-ENODEV);
> >=20
> > -	io_res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	if (!io_res) {
> > -		DRM_ERROR("No registers defined.\n");
> > -		return ERR_PTR(-ENODEV);
> > -	}
> > -
> >  	mdev =3D devm_kzalloc(dev, sizeof(*mdev), GFP_KERNEL);
> >  	if (!mdev)
> >  		return ERR_PTR(-ENOMEM);
> > @@ -192,7 +185,7 @@ struct komeda_dev *komeda_dev_create(struct device =
*dev)
> >  	mutex_init(&mdev->lock);
> >=20
> >  	mdev->dev =3D dev;
> > -	mdev->reg_base =3D devm_ioremap_resource(dev, io_res);
> > +	mdev->reg_base =3D devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(mdev->reg_base)) {
> >  		DRM_ERROR("Map register space failed.\n");
> >  		err =3D PTR_ERR(mdev->reg_base);
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>=20


--=20
Mihail