Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191106174804.74723-1-edumazet@google.com> <alpine.DEB.2.21.1911061908070.1869@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1911061908070.1869@nanos.tec.linutronix.de>
From:   Eric Dumazet <edumazet@google.com>
Date:   Wed, 6 Nov 2019 10:19:44 -0800
Message-ID: <CANn89iK12QGBagUiNr+j-ToawJ9J1behtySyL9vLattYPAD-7w@mail.gmail.com>
Subject: Re: [PATCH] hrtimer: Annotate lockless access to timer->state
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        syzbot <syzkaller@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 6, 2019 at 10:09 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Wed, 6 Nov 2019, Eric Dumazet wrote:
> > @@ -1013,8 +1013,9 @@ static void __remove_hrtimer(struct hrtimer *timer,
> >  static inline int
> >  remove_hrtimer(struct hrtimer *timer, struct hrtimer_clock_base *base, bool restart)
> >  {
> > -     if (hrtimer_is_queued(timer)) {
> > -             u8 state = timer->state;
> > +     u8 state = timer->state;
>
> Shouldn't that be a read once then at least for consistency sake?

We own the lock here, this is not really needed ?

Note they are other timer->state reads I chose to leave unchanged.

But no big deal if you prefer I can add a READ_ONCE()

Thanks.
>
> > +
> > +     if (state & HRTIMER_STATE_ENQUEUED) {
> >               int reprogram;
>
> Thanks,
>
>         tglx