Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp930276ybx; Wed, 6 Nov 2019 10:29:58 -0800 (PST) X-Google-Smtp-Source: APXvYqzEOa2fshDcHzUzc9v4eqI2HwntV7O7/4VW7liFCGHj93JlpUTOdo1ehOmjIWdaDrSeis4S X-Received: by 2002:aa7:c756:: with SMTP id c22mr4265120eds.25.1573064998045; Wed, 06 Nov 2019 10:29:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573064998; cv=none; d=google.com; s=arc-20160816; b=DZQJvGXGC2ngUIGYjLsthqQIuGpkNecWE4ymY0k3w6Gh52K0u9hwmUld1FZ4TSUDFd 6yzS9LCmqX+hgYtk3Z2fqbDO7nRiVyHx887gJ2z1+jfGg/EZO6jfFLu2L6sO1Leu9V6J LLcGz/E+XQs/xK8oslfsH3cI5SHNIx2bONLEefIQBzfTuT5CAdKGm1gqNdUNrDH7ibvJ hZMjNWWL8tltP/2iBnBAS9td75zsUR2QuWkQhHtPCDhsSuMPq9XWF4DxS3bi3IC9TlZv xMx8zgXA3URyep+YqQFQiOPvjpokRhZgyUVcXTwWlC/3r+8XkiAk9O1C6sydkiv37BOL zm1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=R76iUt+tExH00rPBSW1CnywrQg+adJ7KBsNhk3qA/c0=; b=R+u4qSSdCTkMBNixarnRuF6toMcdFmczT8EVE791pF9AOntZoqsomyAPTDHO6LXZLY MqxgiL2D0yN1hWnQw42eYYCqFtjSzgQo9NCLvwUa3piJVdci5D6JNLGiFYbbG+7xelLw xdx07UmQZOci8u0KRYixFRrlPCZYoOhHG7TUYQZrdTqVZ7DWgS5ggTWoJq4ionB0vAKq zR45r9cIFwB567Zx1zIZGnT7Rvjx8jbgGfdxRsxOedONsd8UMfMm9f+et6Uz+tsn+agO 3d3apVpkGb5/2vxmqsof28EfuRHYFSyY7Va36DAaiLxf+MckA7rnkF7GZcpp/xA8kWhX GCOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ca22si8975488ejb.22.2019.11.06.10.29.34; Wed, 06 Nov 2019 10:29:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732495AbfKFS3C (ORCPT + 99 others); Wed, 6 Nov 2019 13:29:02 -0500 Received: from verein.lst.de ([213.95.11.211]:52707 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727276AbfKFS3C (ORCPT ); Wed, 6 Nov 2019 13:29:02 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id B095A68AFE; Wed, 6 Nov 2019 19:28:57 +0100 (CET) Date: Wed, 6 Nov 2019 19:28:57 +0100 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Palmer Dabbelt , Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-m68k , Openrisc , Greentime Hu , MTD Maling List , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , linux-mips@vger.kernel.org, alpha , nios2-dev@lists.rocketboards.org Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Message-ID: <20191106182857.GA21062@lst.de> References: <20191029064834.23438-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2019 at 07:16:38PM +0100, Geert Uytterhoeven wrote: > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Eventually we should unify it and only have a single prototype. But we have lots of implementations including inline functions, so this will take a few more steps.