Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <87y2ws3lvh.fsf@kamboji.qca.qualcomm.com>
References: <20191101054035.42101-1-ikjn@chromium.org> <87y2ws3lvh.fsf@kamboji.qca.qualcomm.com>
From:   Tom Psyborg <pozega.tomislav@gmail.com>
Date:   Wed, 6 Nov 2019 19:33:54 +0100
Message-ID: <CAKR_QVKqGv+hpiENHmNFE4y=FY+Mqb7cAh7_5xhTXH27HW+Taw@mail.gmail.com>
Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware.
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Ikjoon Jang <ikjn@chromium.org>, netdev@vger.kernel.org,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        ath10k@lists.infradead.org,
        "David S . Miller" <davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06/11/2019, Kalle Valo <kvalo@codeaurora.org> wrote:
> Ikjoon Jang <ikjn@chromium.org> writes:
>
>> Downloading ath10k firmware needs a large number of IOs and
>> cpuidle's miss predictions make it worse. In the worst case,
>> resume time can be three times longer than the average on sdio.
>>
>> This patch disables cpuidle during firmware downloading by
>> applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw().
>>
>> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>
> On what hardware and firmware versions did you test this? I'll add that
> to the commit log.
>
> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines
>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
>

Hi

I've tested this on QCA9880. No issues during firmware download.