Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Nov 2019 20:01:21 +0100
From:   Pavel Machek <pavel@denx.de>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Thierry Reding <treding@nvidia.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.19 078/149] gpio: max77620: Use correct unit for
 debounce times
Message-ID: <20191106190121.GA2306@amd>
References: <20191104212126.090054740@linuxfoundation.org>
 <20191104212142.090938480@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62"
Content-Disposition: inline
In-Reply-To: <20191104212142.090938480@linuxfoundation.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> The gpiod_set_debounce() function takes the debounce time in
> microseconds. Adjust the switch/case values in the MAX77620 GPIO to use
> the correct unit.


> +++ b/drivers/gpio/gpio-max77620.c
> @@ -163,13 +163,13 @@ static int max77620_gpio_set_debounce(struct max776=
20_gpio *mgpio,
>  	case 0:
>  		val =3D MAX77620_CNFG_GPIO_DBNC_None;
>  		break;
> -	case 1 ... 8:
> +	case 1000 ... 8000:
>  		val =3D MAX77620_CNFG_GPIO_DBNC_8ms;
>  		break;

AFAICT the range should be 1 ... 8000, then 8001 ... 16000 etc below...

> -	case 9 ... 16:
> +	case 9000 ... 16000:
>  		val =3D MAX77620_CNFG_GPIO_DBNC_16ms;
>  		break;
> -	case 17 ... 32:
> +	case 17000 ... 32000:
>  		val =3D MAX77620_CNFG_GPIO_DBNC_32ms;
>  		break;
>  	default:

Best regards,
									Pavel

--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--+QahgC5+KEYLbs62
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAl3DGIEACgkQMOfwapXb+vKDjACdEBrHzhRnSS2tlzRywsjY1nqB
AWYAn237wdZfhpbkxh6xewtJbqZA4PRp
=4/4n
-----END PGP SIGNATURE-----

--+QahgC5+KEYLbs62--