To: Andi Kleen <ak@suse.de>
Cc: "Bryan O'Sullivan" <bos@pathscale.com>, akpm@osdl.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2 of 2] __raw_memcpy_toio32 for x86_64
References: <f03a807a80b8bc45bf91.1137025776@eng-12.pathscale.com>
	<200601120156.11529.ak@suse.de> <adaace2i6lr.fsf@cisco.com>
	<200601120227.45209.ak@suse.de>
From: Roland Dreier <rdreier@cisco.com>
Date: Wed, 11 Jan 2006 17:32:03 -0800
In-Reply-To: <200601120227.45209.ak@suse.de> (Andi Kleen's message of "Thu,
 12 Jan 2006 02:27:44 +0100")
Message-ID: <ada64oqi63w.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.17 (Jumbo Shrimp, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 560
Lines: 13

    Andi> Well then they can just as well use normal memcpy as long as
    Andi> they don't pass any sizes % 4 != 0. That should be ok as
    Andi> long as they add a comment there.

But then the driver will be doing memcpy() to I/O memory, which may
work by chance on x86_64 but will blow up on other archs.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/