Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp203774ybx; Wed, 6 Nov 2019 15:40:09 -0800 (PST) X-Google-Smtp-Source: APXvYqwZPF4l/6mOyTBvod2P+9+NfEqkZJZjfMNMj+cwEf9StSMdOlN6qoqZXErQd0W5O6t651IH X-Received: by 2002:a17:906:4019:: with SMTP id v25mr253086ejj.11.1573083609160; Wed, 06 Nov 2019 15:40:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573083609; cv=none; d=google.com; s=arc-20160816; b=nqDBrxt4WswKPTg78kRaUZENKczGih2Plj4YgmwusE/p4EKy7A9Lid5zq+ZWKtTeWq Z86Z/hIeNPULnlIIXwdwXnGghvYHs88WJJUK8ArEIQ+vN1DdB6TnSwQCr3GaCXm7c2aC LX6FYFcfqCpRxQx7/oRr202M5N8XvusPx0GDRKotpZYGf2kWkdCFEGKSaC4KNHwj5yT+ I+gQdCm7zmmxuvjdb9ZxPA0GHC+tdV8JiO99WCf5ZeAQE4z+gdkR8HHm7hiaHu5uoUWd y6pU+t/oQ8bPbQunO4I+N8lhu3Vo84/GIvjCsPWiZt4cTexEIbHYolIf58rFouxyrVC5 lZKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=NXCGiVKTXXEjzDxDKPWm4qRbQINthtPG/DF3mE8dX04=; b=yA2EpB+/yCwMCW9JBCHonCGyHmHmFA+cACtkyw3QpvfMP5j3Fj+96azoyFr4g7Tbc1 UJUe6RquP5FbRSKbjKri7Jcq+mHjbPV1cWwrQJDzvDZ8QOtD8tXNTz2vV42lgeFDItUE KlAjw3g9gBABzoQTPc2YgMxFpf3OyBtOuqdBmwaF9YFf+os623ciFRS9eIBbfCGkdGRT 0yCkvBiXLwxW3HSvHxesE+pkooq4pnU5VOBF5XhVJ5lSmQ4vDFtUHBwvkOU1isa5FeVH h4p26fsHAX4ZW+1JHAc5aqcBj9I28znYAjYy1sgXaXoHsP94Rk01uP3dErobfqo4tvmc S1sQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=kxCPnkll; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h90si119319edd.178.2019.11.06.15.39.45; Wed, 06 Nov 2019 15:40:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=kxCPnkll; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732807AbfKFXiy (ORCPT + 99 others); Wed, 6 Nov 2019 18:38:54 -0500 Received: from mail-yb1-f195.google.com ([209.85.219.195]:36961 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728065AbfKFXix (ORCPT ); Wed, 6 Nov 2019 18:38:53 -0500 Received: by mail-yb1-f195.google.com with SMTP id e13so238622ybh.4 for ; Wed, 06 Nov 2019 15:38:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=NXCGiVKTXXEjzDxDKPWm4qRbQINthtPG/DF3mE8dX04=; b=kxCPnkllRFkeV9ZKT0vPLK4zwrVw+ZIGPflI0u5vk0j5pV5zLWHRpkAzf35kkz/5XC RIlII4oE7WfBPgvN2mVCbQYEo9K5fyHa0b87urxXjOe1LqWcNYx1mQ+M1OENSM6qPNc1 KKlDhCAKesadT+zSpoL5FMzs/ZDI2z/yuaG4z8Lh7st3mJDDhqDucU7bYyX8r6Tx8tTv IvWbK17y0NFyGnmfQKAGivMO8CFlccpSFp0KyWcXwip0cWszVzs5oguhC41DP9kdj+vc uzSbWQgVizDX0lT+3W8BRm8iLDVZd530GuZg1sYszeXs4yPAj/n7rNX/rkb6bP6sTFt1 SRCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=NXCGiVKTXXEjzDxDKPWm4qRbQINthtPG/DF3mE8dX04=; b=sfTarDzSu2lROpWp+kc7YokLRXIJMCd0JB8YBbY997H9FuDwmz0gtaooz3tuqqxgfp 6OQFhDLVaXGTbsTX+uwxeT2MCtwoqjTbeUjlVb6WDghtvU/WjMPx95SLbjjQ7Pan0yBV nOCt3gkD5kkFR6WyrUO/zv5Szr0Z9sKpR2/n5a3jz050RElJOrOzSypS9X4c35b67kwf THMSXySKo6fdpwIZmUvQT021UuIZsMyR3/E6HHhdQsbKGW/aKBTmdcycwosKhPgh2Sfm ttUkt7X3lC30rKM01hnVtla8PAFyJ+PPNyFgN7SXHF8pt7SXNrxl91XIjt23/7Tq08ns 62aw== X-Gm-Message-State: APjAAAVNhKFuocX+YDVyeErLUyGzj+RzuvfoWLyhRvscgIHk7+pCECcA irkDdx5jDIXakZzbu5MEOIpyanxa3PM= X-Received: by 2002:a25:af05:: with SMTP id a5mr633074ybh.155.1573083531576; Wed, 06 Nov 2019 15:38:51 -0800 (PST) Received: from cakuba.netronome.com ([64.63.152.34]) by smtp.gmail.com with ESMTPSA id z127sm194842ywb.38.2019.11.06.15.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2019 15:38:51 -0800 (PST) Date: Wed, 6 Nov 2019 18:38:48 -0500 From: Jakub Kicinski To: Jonas Bonn Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: [PATCH v2 1/5] rtnetlink: allow RTM_SETLINK to reference other namespaces Message-ID: <20191106183848.3b914620@cakuba.netronome.com> In-Reply-To: <20191106053923.10414-2-jonas@norrbonn.se> References: <20191106053923.10414-1-jonas@norrbonn.se> <20191106053923.10414-2-jonas@norrbonn.se> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Nov 2019 06:39:19 +0100, Jonas Bonn wrote: > + if (tb[IFLA_TARGET_NETNSID]) { > + int32_t netnsid = nla_get_s32(tb[IFLA_TARGET_NETNSID]); > + tgt_net = rtnl_get_net_ns_capable(NETLINK_CB(skb).sk, netnsid); No comments on merits but you should definitely run this through checkpatch..