Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp220703ybx; Wed, 6 Nov 2019 16:00:22 -0800 (PST) X-Google-Smtp-Source: APXvYqwkE4XUx2jTXzVVhQMxJYBhWMqBz0VPF70vqSn27hDR8bZotzjpdUTaOAKhtoN/oegGL/f+ X-Received: by 2002:a17:906:80c:: with SMTP id e12mr314450ejd.59.1573084822770; Wed, 06 Nov 2019 16:00:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573084822; cv=none; d=google.com; s=arc-20160816; b=H12e4JG/EXs2PyBIRHIf5iPG8nta35qfdmu02V2yocYg/HySqw5LzsfwlW/3SyntoH gLXSWFbbzOpKSR9X5i/NW8LN7MMkefWbQoPPyNvlma5Ka6R2qBDTPenKOdnz/mNz9E1k 8qFUz53k0xmByJdHnCpjqA5/VeONQJK6X1zgrPSzmPkpHT4KKb7XW+Sqv11Eu3+1+5LY c1iPW3+UnKNr2WP70ZvtToSfJ+u+42ql6sowmG4ReoQYEdPUTjPmpgh2uy7pp4ChdSNu Q6O8tQAxO/UJD0KQCAofIwLedHB/R2PnyEUT5AzG2/TZ70eH7ZsAokRt1SQRR0wWmUev xcUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=DYf8aAMmRvjXUQpfphEhKk+3TLfQLLQK5Utz/xmwQg4=; b=aGFvkp5X6+xiOA63XbtsTjWieTq85oKGJCKmrb9zPI3WDR1YVXaf2HQu9HFHb8vAws hlcoUFyNAhPGPvVu1C81qPieljBvyHSwkZ0mNJB+ni/AVCjSBN3eBvUn2dMeqzl7ZKNp RiKyRSrQBVDT5X/csaP0rTGugolXTLvHWEgO9GucjEMP3f++RLRIuEvjbZ/wIboTPfWA NTa1fbRJD5JZyONKtZEtychpgBnGjJv6a7pkjj7s3BsvzbTUBihGLS1xcIIt6T13jNHe lVh+/f2UxtMlNBnhW1zTIzesDpNrex0TNLPLBMsNI9B/KlEPDGSbPJERbc9PETkVl5Po qgwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eNEWXheY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si236047ejd.305.2019.11.06.15.59.59; Wed, 06 Nov 2019 16:00:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eNEWXheY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732292AbfKFX7M (ORCPT + 99 others); Wed, 6 Nov 2019 18:59:12 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43406 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727393AbfKFX7M (ORCPT ); Wed, 6 Nov 2019 18:59:12 -0500 Received: by mail-lf1-f68.google.com with SMTP id j5so69385lfh.10; Wed, 06 Nov 2019 15:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DYf8aAMmRvjXUQpfphEhKk+3TLfQLLQK5Utz/xmwQg4=; b=eNEWXheYDRU8KdxiR6Eq6OKP9rbfiwIXWnSwfYK3lptAs0cRbbRl01t9JcVXalaIh5 y5sxUuHGokzteBEcjK8mBHHkoLq7JHMnn23V5W2mJhBUiIUgrvl3oF1pq+sr1z6cBJxv w3eHDjFYfJezAaK/NsMEUKVVIZJ5TFDG0We2gyWI/AhQ9SkdJVHsJ0ZneMp9Jx+SgXap z+nmvDEKuEG02F8kN6/mSP+9g9L/m4RB4Wh4NGMx1ahdpnOvw+Wkbk/+oPC0sNKgqNHa y7BNrhoLlxgtUoxnGZN71FSRLbeSQtVJfsGUeU2dF8SNF0Z5rBiZap12A/JP43u9aKuf FaEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DYf8aAMmRvjXUQpfphEhKk+3TLfQLLQK5Utz/xmwQg4=; b=SqkNxOm9mNNmMAaYq8NtzL+t8ik8a+7v4+MP8MbZprxUKbwjkSX39EkSDwbvWmBVd3 4ItxkcdAjvC9Vytfni3NHfoXcu1p291bWS6R8acEqMha7X/60KvP9CGVScK1Ep3CkBJ7 6D28jrG+TOVK/6t54tcEs1KSwy8PuW5QJcHg1PQrzCQgAHakN5sSayq3CQqhO+cpMmnA hHxRRRWyMi/5MmeEmzx9za2Vy5jPZD2SsZFtPYYXyGyLs/5DKpD8eqCigPla1MDN32hQ M6UY5UisbQ7cu2YJUMNPzM1vDIcI1UwrkHP91nVJEYyR7PeLjYjy4jxOcNNAbfQyMUU3 VUIg== X-Gm-Message-State: APjAAAXCrBTX2BgJnHkFmcBMdwPhGoF0cJIV3WxPGDrVBivSrvA1L8Qu TtUmQC0PnUgXQ/FK2B+Oub/25IL8wlYao8mC1/k= X-Received: by 2002:a19:6454:: with SMTP id b20mr69757lfj.159.1573084748421; Wed, 06 Nov 2019 15:59:08 -0800 (PST) MIME-Version: 1.0 References: <20191029223214.18889-1-linux@roeck-us.net> <20191030005327.GC15332@redsun51.ssa.fujisawa.hgst.com> <20191106212921.GA7020@amd> In-Reply-To: <20191106212921.GA7020@amd> From: Chris Healy Date: Wed, 6 Nov 2019 15:58:56 -0800 Message-ID: Subject: Re: [PATCH v2] nvme: Add hardware monitoring support To: Pavel Machek Cc: Keith Busch , Guenter Roeck , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-kernel , linux-nvme@lists.infradead.org, Akinobu Mita , linux-pm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > Signed-off-by: Guenter Roeck > > > > This looks fine to me, but I'll wait a few more days to see if there ar= e > > any additional comments.. > > User wants to know temperature of /dev/sda... and we already have an > userspace tools knowing about smart, etc... At least for my use cases, being able to use the thermal subsystem of the kernel to cool things down when the SSD gets too hot is important. Is there a way to do this with userspace tools feeding back to the kernel's thermal subsystem? > > pavel@amd:/data/film$ sudo hddtemp /dev/sda > /dev/sda: ST1000LM014-1EJ164: 48=C2=B0C > > I see we also have sensors framework but it does _not_ handle > harddrive temperatures. > > Does it need some kind of unification? Should NVMe devices expose > "SMART" information in the same way other SSDs do? > > Best regards, > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/b= log.html