Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Nov 2019 21:34:58 -0600
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Joe Lawrence <joe.lawrence@redhat.com>
Cc:     linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Subject: Re: [PATCH v2] x86/stacktrace: update kconfig help text for reliable
 unwinders
Message-ID: <20191107033458.ptvw6omypqndjt6d@treble>
References: <20191107032958.14034-1-joe.lawrence@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20191107032958.14034-1-joe.lawrence@redhat.com>
User-Agent: NeoMutt/20180716
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 06, 2019 at 10:29:58PM -0500, Joe Lawrence wrote:
> commit 6415b38bae26 ("x86/stacktrace: Enable HAVE_RELIABLE_STACKTRACE
> for the ORC unwinder") added the ORC unwinder as a "reliable" unwinder.
> Update the help text to reflect that change: the frame pointer unwinder
> is no longer the only one that can provide HAVE_RELIABLE_STACKTRACE.
>=20
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
>=20
> v2: dropped hunk that added unnecessary text to UNWIND_GUESS
>=20
>  arch/x86/Kconfig.debug | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index bf9cd83de777..409c00f74e60 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -316,10 +316,6 @@ config UNWINDER_FRAME_POINTER
>  =09  unwinder, but the kernel text size will grow by ~3% and the kernel'=
s
>  =09  overall performance will degrade by roughly 5-10%.
> =20
> -=09  This option is recommended if you want to use the livepatch
> -=09  consistency model, as this is currently the only way to get a
> -=09  reliable stack trace (CONFIG_HAVE_RELIABLE_STACKTRACE).
> -
>  config UNWINDER_GUESS
>  =09bool "Guess unwinder"
>  =09depends on EXPERT
> --=20
> 2.21.0
>=20

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

--=20
Josh