Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v5] vhost: introduce mdev based hardware backend
To:     Tiwei Bie <tiwei.bie@intel.com>,
        "Michael S. Tsirkin" <mst@redhat.com>
Cc:     alex.williamson@redhat.com, maxime.coquelin@redhat.com,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        dan.daly@intel.com, cunming.liang@intel.com,
        zhihong.wang@intel.com, lingshan.zhu@intel.com
References: <20191105115332.11026-1-tiwei.bie@intel.com>
 <20191106075733-mutt-send-email-mst@kernel.org> <20191106143907.GA10776@___>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <def13888-c99f-5f59-647b-05a4bb2f8657@redhat.com>
Date:   Thu, 7 Nov 2019 12:16:01 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191106143907.GA10776@___>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/11/6 =E4=B8=8B=E5=8D=8810:39, Tiwei Bie wrote:
> On Wed, Nov 06, 2019 at 07:59:02AM -0500, Michael S. Tsirkin wrote:
>> On Tue, Nov 05, 2019 at 07:53:32PM +0800, Tiwei Bie wrote:
>>> This patch introduces a mdev based hardware vhost backend.
>>> This backend is built on top of the same abstraction used
>>> in virtio-mdev and provides a generic vhost interface for
>>> userspace to accelerate the virtio devices in guest.
>>>
>>> This backend is implemented as a mdev device driver on top
>>> of the same mdev device ops used in virtio-mdev but using
>>> a different mdev class id, and it will register the device
>>> as a VFIO device for userspace to use. Userspace can setup
>>> the IOMMU with the existing VFIO container/group APIs and
>>> then get the device fd with the device name. After getting
>>> the device fd, userspace can use vhost ioctls on top of it
>>> to setup the backend.
>>>
>>> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>> So at this point, looks like the only thing missing is IFC, and then all
>> these patches can go in.
>> But as IFC is still being worked on anyway, it makes sense to
>> address the minor comments manwhile so we don't need
>> patches on top.
>> Right?
> Yeah, of course.
>
> Thanks,
> Tiwei


Please send V6 and I will ack there.

Thanks