Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Nov 2019 09:18:37 +0100
From:   Johan Hovold <johan@kernel.org>
To:     Pan Bian <bianpan2016@163.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Johannes Berg <johannes.berg@intel.com>,
        Steve Winslow <swinslow@gmail.com>,
        Young Xiao <92siuyang@gmail.com>,
        Allison Randal <allison@lohutok.net>,
        Michal Kubecek <mkubecek@suse.cz>,
        Andrey Konovalov <andreyknvl@google.com>,
        Thomas Gleixner <tglx@linutronix.de>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nfc: netlink: fix double device reference drop
Message-ID: <20191107081837.GF11035@localhost>
References: <1573108190-30836-1-git-send-email-bianpan2016@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1573108190-30836-1-git-send-email-bianpan2016@163.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 07, 2019 at 02:29:50PM +0800, Pan Bian wrote:
> The function nfc_put_device(dev) is called twice to drop the reference
> to dev when there is no associated local llcp. Remove one of them to fix
> the bug.
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> v2: change subject of the patch
> ---
>  net/nfc/netlink.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Johan Hovold <johan@kernel.org>

In the future, please try to track down the commits introducing the bugs
you fix. That will help not only reviewers, but also the stable
maintainers.

In this case you could have added:

Fixes: 52feb444a903 ("NFC: Extend netlink interface for LTO, RW, and MIUX parameters support")
Fixes: d9b8d8e19b07 ("NFC: llcp: Service Name Lookup netlink interface")

> diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
> index 17e6ca62f1be..afde0d763039 100644
> --- a/net/nfc/netlink.c
> +++ b/net/nfc/netlink.c
> @@ -1099,7 +1099,6 @@ static int nfc_genl_llc_set_params(struct sk_buff *skb, struct genl_info *info)
>  
>  	local = nfc_llcp_find_local(dev);
>  	if (!local) {
> -		nfc_put_device(dev);
>  		rc = -ENODEV;
>  		goto exit;
>  	}
> @@ -1159,7 +1158,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info)
>  
>  	local = nfc_llcp_find_local(dev);
>  	if (!local) {
> -		nfc_put_device(dev);
>  		rc = -ENODEV;
>  		goto exit;
>  	}

Johan