Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: /cpPP5CdBAWMlgP4hU3rCQ58LrOtDF78Hj/zisUzD37sjX/0aSAs7m59kIYCCgzUuDO2N0N9C2
 n9CXKAu40jf7Rzbirjx6JYF8tw1KnVy1HLZPaqV0OaoGy19KQ77QtmaIfRtiqnvxeI6v8eO94x
 ZBYy0gQto1LfCbhafnrNUvIzs9on9EfYu5lVz8aJRQYLeQKmNZpDDIOE7QYCnsDB+OWSvmlgA7
 lTt6pdRztWIlqS2Kj/gXoauVPNZVDVQqFIsKJmTCH20yaJCcr2LJYGdi49GZVfp5QRuiNekX2+
 tLE=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bradley Bolen <bradleybolen@gmail.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
CC:     "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "wsa+renesas@sang-engineering.com" <wsa+renesas@sang-engineering.com>,
        "yinbo.zhu@nxp.com" <yinbo.zhu@nxp.com>,
        "hongjiefang@asrmicro.com" <hongjiefang@asrmicro.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] mmc: core: Fix size overflow for mmc partitions
Thread-Topic: [PATCH v2] mmc: core: Fix size overflow for mmc partitions
Thread-Index: AQHVlRsip+rrxfkAO0KNHDyPQxqMrqd/YMxA
Date:   Thu, 7 Nov 2019 08:30:22 +0000
Message-ID: <MN2PR04MB69915AFED1B6AFD1B30EFBCDFC780@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <1573097159-3914-1-git-send-email-bradleybolen@gmail.com>
In-Reply-To: <1573097159-3914-1-git-send-email-bradleybolen@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 815b8989-178b-44d4-1506-08d7635cbb86
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 08:30:22.9436
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NHkAxlX42H7bwK8KsdT8NXNrH+enuSlLcSfzo7t4M3/j5RLK4zGcwYWnUcCmbKtGtSprVdiQLdsFNC9POuXW0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6942
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> With large eMMC cards, it is possible to create general purpose partition=
s that
> are bigger than 4GB.  The size member of the mmc_part struct is only an
> unsigned int which overflows for gp partitions larger than 4GB.  Change t=
his to a
> u64 to handle the overflow.
>=20
> Signed-off-by: Bradley Bolen <bradleybolen@gmail.com>
Looks fine.
Avri

> ---
>  drivers/mmc/core/mmc.c   | 6 +++---
>  include/linux/mmc/card.h | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index
> c880489..fc02124 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -297,7 +297,7 @@ static void mmc_manage_enhanced_area(struct
> mmc_card *card, u8 *ext_csd)
>         }
>  }
>=20
> -static void mmc_part_add(struct mmc_card *card, unsigned int size,
> +static void mmc_part_add(struct mmc_card *card, u64 size,
>                          unsigned int part_cfg, char *name, int idx, bool=
 ro,
>                          int area_type)
>  {
> @@ -313,7 +313,7 @@ static void mmc_manage_gp_partitions(struct
> mmc_card *card, u8 *ext_csd)  {
>         int idx;
>         u8 hc_erase_grp_sz, hc_wp_grp_sz;
> -       unsigned int part_size;
> +       u64 part_size;
>=20
>         /*
>          * General purpose partition feature support -- @@ -362,7 +362,7 =
@@
> static void mmc_manage_gp_partitions(struct mmc_card *card, u8 *ext_csd)
> static int mmc_decode_ext_csd(struct mmc_card *card, u8 *ext_csd)  {
>         int err =3D 0, idx;
> -       unsigned int part_size;
> +       u64 part_size;
>         struct device_node *np;
>         bool broken_hpi =3D false;
>=20
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index
> 9b6336a..b59d35b 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -226,7 +226,7 @@ struct mmc_queue_req;
>   * MMC Physical partitions
>   */
>  struct mmc_part {
> -       unsigned int    size;   /* partition size (in bytes) */
> +       u64             size;   /* partition size (in bytes) */
>         unsigned int    part_cfg;       /* partition type */
>         char    name[MAX_MMC_PART_NAME_LEN];
>         bool    force_ro;       /* to make boot parts RO by default */
> --
> 2.7.4