Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp737528ybx; Thu, 7 Nov 2019 01:54:30 -0800 (PST) X-Google-Smtp-Source: APXvYqw97ILzdcWVczIGaOtZy9cnmhXCJfs7RCEElvRU547QAATQURUZBpQppm6z1+YMH8JqRqzM X-Received: by 2002:a17:907:1102:: with SMTP id qu2mr2069206ejb.300.1573120470745; Thu, 07 Nov 2019 01:54:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573120470; cv=none; d=google.com; s=arc-20160816; b=cF7UFJoAffKTw/pFjyFFF9z2mwNxezm+Qp3/hCNIdEGVAihZ6j1W56wtCLIQq3USLa B/F2jMf822GJg1Ixa+S8kI+Rk1jPiM8AKLf7nClgE0SQTc5t49KSIOombmCeBVRedQfB n4yXE+2+7T22p1tuAEm6Vs7CkRyEBtLpdfllCzwFM3keuVN2epEe+FK+D0C7KrzDiLfL 31USpsDBFr2UvhrLmvAarvRm7Mf8ZmW50TaLDoXcS9n/KfG091Qx5R45cN0fVMWM1CBy lSOJrqGcg8H6JnKKotnPlr3RpqysH+iKyoi34A6hJo4LQKP3YrXzEHEaP14MsSgDyNDj uhZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=trwx3J088ifMSXDlrnn6C1GkVE/t8HLHXAAVx/62/F8=; b=u+YH/DZjxscUMRusXAEApYjmzw9l9659WE5nT00wH+EURxLVCva3WY75W8x5aoczK5 xqwoVkJLZ/zPK5nxtvGWmYdX3aZwzavj4QtwhKxAehqJpxKlAx8gBqOlb0cH/L0CNhxE W94RseNfG9cGA/vPrNkSk7tR2txz/lQRAcMes98CbGCJeUeR0/aRZtqwTETDMp8NeVUj hElXREVlHf0gYgCZuGYZRmJvOBetdjOowjDHDcd2CJUv5w/ABxBkyzYqbfrm+FdTSOv8 Qq2XhDZ58hcoLSHFzUhooqF3xz5dE4lANK2u6/2PPt54x0KpArOZYRtSP7TB1Kem1Zin Hmew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@xenosoft.de header.s=strato-dkim-0002 header.b=p0tRWyvU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9si1017095edf.35.2019.11.07.01.54.06; Thu, 07 Nov 2019 01:54:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@xenosoft.de header.s=strato-dkim-0002 header.b=p0tRWyvU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387905AbfKGJxU (ORCPT + 99 others); Thu, 7 Nov 2019 04:53:20 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]:15081 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfKGJxU (ORCPT ); Thu, 7 Nov 2019 04:53:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573120397; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=trwx3J088ifMSXDlrnn6C1GkVE/t8HLHXAAVx/62/F8=; b=p0tRWyvUrsAKuR7Cdb/9SoUraIZ+SAQTtE8ybtVWqM4cH+sh9TGf1KrrsAwo6MYzHY WoaHimNaFyXG2jJH6Epnu0xQ8UZtXwaumLfMMJWRxHO/iWJuNRt0fU5n7oXKzUMWO07Z XXdGRmZeu3TmWLp5y/MWDVyFTazhc3j4uDfD0OSBRyc5S8kU9JWMuGuRr81Ch8rjBPVz HYv/RfMQqFvxOwYm6JxNLrdQSrzmQck+UGipm4GI6RXlPBg0XLdCP6BznRh6IZ93ho/A Kwcu2/lNlt1mICFRiK1+tr7nWCfS3JTZjFSRpiHSKJLXw1020wyvVseuGQwywR1tMCCX ctDg== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5DdBJSrwuuqxvPhWJ4neaR1DEPK76ZrzkovbziPV9Q==" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:89c0:ebfc:5146:21ae:8547:c1e0] by smtp.strato.de (RZmta 44.29.0 AUTH) with ESMTPSA id q007c8vA79rB0Ct (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 7 Nov 2019 10:53:11 +0100 (CET) Subject: Re: Bug 205201 - overflow of DMA mask and bus mask To: Christoph Hellwig Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Benjamin Herrenschmidt , paulus@samba.org, darren@stevens-zone.net, "contact@a-eon.com" , rtd2@xtra.co.nz, mad skateman , Rob Herring , linuxppc-dev References: <20181213112511.GA4574@lst.de> <008c981e-bdd2-21a7-f5f7-c57e4850ae9a@xenosoft.de> <20190103073622.GA24323@lst.de> <71A251A5-FA06-4019-B324-7AED32F7B714@xenosoft.de> <1b0c5c21-2761-d3a3-651b-3687bb6ae694@xenosoft.de> <3504ee70-02de-049e-6402-2d530bf55a84@xenosoft.de> <46025f1b-db20-ac23-7dcd-10bc43bbb6ee@xenosoft.de> <20191105162856.GA15402@lst.de> From: Christian Zigotzky Message-ID: <2f3c81bd-d498-066a-12c0-0a7715cda18f@xenosoft.de> Date: Thu, 7 Nov 2019 10:53:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191105162856.GA15402@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: de-DE Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05 November 2019 at 5:28 pm, Christoph Hellwig wrote: > On Tue, Nov 05, 2019 at 08:56:27AM +0100, Christian Zigotzky wrote: >> Hi All, >> >> We still have DMA problems with some PCI devices. Since the PowerPC updates >> 4.21-1 [1] we need to decrease the RAM to 3500MB (mem=3500M) if we want to >> work with our PCI devices. The FSL P5020 and P5040 have these problems >> currently. >> >> Error message: >> >> [   25.654852] bttv 1000:04:05.0: overflow 0x00000000fe077000+4096 of DMA >> mask ffffffff bus mask df000000 >> >> All 5.x Linux kernels can't initialize a SCSI PCI card anymore so booting >> of a Linux userland isn't possible. >> >> PLEASE check the DMA changes in the PowerPC updates 4.21-1 [1]. The kernel >> 4.20 works with all PCI devices without limitation of RAM. > Can you send me the .config and a dmesg? And in the meantime try the > patch below? > > --- > >From 4d659b7311bd4141fdd3eeeb80fa2d7602ea01d4 Mon Sep 17 00:00:00 2001 > From: Nicolas Saenz Julienne > Date: Fri, 18 Oct 2019 13:00:43 +0200 > Subject: dma-direct: check for overflows on 32 bit DMA addresses > > As seen on the new Raspberry Pi 4 and sta2x11's DMA implementation it is > possible for a device configured with 32 bit DMA addresses and a partial > DMA mapping located at the end of the address space to overflow. It > happens when a higher physical address, not DMAable, is translated to > it's DMA counterpart. > > For example the Raspberry Pi 4, configurable up to 4 GB of memory, has > an interconnect capable of addressing the lower 1 GB of physical memory > with a DMA offset of 0xc0000000. It transpires that, any attempt to > translate physical addresses higher than the first GB will result in an > overflow which dma_capable() can't detect as it only checks for > addresses bigger then the maximum allowed DMA address. > > Fix this by verifying in dma_capable() if the DMA address range provided > is at any point lower than the minimum possible DMA address on the bus. > > Signed-off-by: Nicolas Saenz Julienne > --- > include/linux/dma-direct.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/dma-direct.h b/include/linux/dma-direct.h > index adf993a3bd58..6ad9e9ea7564 100644 > --- a/include/linux/dma-direct.h > +++ b/include/linux/dma-direct.h > @@ -3,6 +3,7 @@ > #define _LINUX_DMA_DIRECT_H 1 > > #include > +#include /* for min_low_pfn */ > #include > > #ifdef CONFIG_ARCH_HAS_PHYS_TO_DMA > @@ -27,6 +28,13 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) > if (!dev->dma_mask) > return false; > > +#ifndef CONFIG_ARCH_DMA_ADDR_T_64BIT > + /* Check if DMA address overflowed */ > + if (min(addr, addr + size - 1) < > + __phys_to_dma(dev, (phys_addr_t)(min_low_pfn << PAGE_SHIFT))) > + return false; > +#endif > + > return addr + size - 1 <= > min_not_zero(*dev->dma_mask, dev->bus_dma_mask); > } Hello Christoph, Thanks a lot for your patch! Unfortunately this patch doesn't solve the issue. Error messages: [    6.041163] bttv: driver version 0.9.19 loaded [    6.041167] bttv: using 8 buffers with 2080k (520 pages) each for capture [    6.041559] bttv: Bt8xx card found (0) [    6.041609] bttv: 0: Bt878 (rev 17) at 1000:04:05.0, irq: 19, latency: 128, mmio: 0xc20001000 [    6.041622] bttv: 0: using: Typhoon TView RDS + FM Stereo / KNC1 TV Station RDS [card=53,insmod option] [    6.042216] bttv: 0: tuner type=5 [    6.111994] bttv: 0: audio absent, no audio device found! [    6.176425] bttv: 0: Setting PLL: 28636363 => 35468950 (needs up to 100ms) [    6.200005] bttv: PLL set ok [    6.209351] bttv: 0: registered device video0 [    6.211576] bttv: 0: registered device vbi0 [    6.214897] bttv: 0: registered device radio0 [  114.218806] bttv 1000:04:05.0: overflow 0x00000000ff507000+4096 of DMA mask ffffffff bus mask df000000 [  114.218848] Modules linked in: rfcomm bnep tuner_simple tuner_types tea5767 tuner tda7432 tvaudio msp3400 bttv tea575x tveeprom videobuf_dma_sg videobuf_core rc_core videodev mc btusb btrtl btbcm btintel bluetooth uio_pdrv_genirq uio ecdh_generic ecc [  114.219012] [c0000001ecddf720] [80000000008ff6e8] .buffer_prepare+0x150/0x268 [bttv] [  114.219029] [c0000001ecddf860] [80000000008fff6c] .bttv_qbuf+0x50/0x64 [bttv] ----- Trace: [  462.783184] Call Trace: [  462.783187] [c0000001c6c67420] [c0000000000b3358] .report_addr+0xb8/0xc0 (unreliable) [  462.783192] [c0000001c6c67490] [c0000000000b351c] .dma_direct_map_page+0xf0/0x128 [  462.783195] [c0000001c6c67530] [c0000000000b35b0] .dma_direct_map_sg+0x5c/0xac [  462.783205] [c0000001c6c675e0] [8000000000862e88] .__videobuf_iolock+0x660/0x6d8 [videobuf_dma_sg] [  462.783220] [c0000001c6c676b0] [8000000000854274] .videobuf_iolock+0x98/0xb4 [videobuf_core] [  462.783271] [c0000001c6c67720] [80000000008686e8] .buffer_prepare+0x150/0x268 [bttv] [  462.783276] [c0000001c6c677c0] [8000000000854afc] .videobuf_qbuf+0x2b8/0x428 [videobuf_core] [  462.783288] [c0000001c6c67860] [8000000000868f6c] .bttv_qbuf+0x50/0x64 [bttv] [  462.783383] [c0000001c6c678e0] [80000000007bf208] .v4l_qbuf+0x54/0x60 [videodev] [  462.783402] [c0000001c6c67970] [80000000007c1eac] .__video_do_ioctl+0x30c/0x3f8 [videodev] [  462.783421] [c0000001c6c67a80] [80000000007c3c08] .video_usercopy+0x18c/0x3dc [videodev] [  462.783440] [c0000001c6c67c00] [80000000007bb14c] .v4l2_ioctl+0x60/0x78 [videodev] [  462.783460] [c0000001c6c67c90] [80000000007d3c48] .v4l2_compat_ioctl32+0x9b4/0x1850 [videodev] [  462.783468] [c0000001c6c67d70] [c0000000001ad9cc] .__se_compat_sys_ioctl+0x284/0x127c [  462.783473] [c0000001c6c67e20] [c00000000000067c] system_call+0x60/0x6c [  462.783475] Instruction dump: [  462.783477] 40fe0044 60000000 892255d0 2f890000 40fe0020 3c82ffc5 39200001 60000000 [  462.783483] 38842029 992255d0 485ad0d9 60000000 <0fe00000> 38210070 e8010010 7c0803a6 [  462.783490] ---[ end trace b677d4a00458e277 ]--- ----- dmesg fsl p5040: https://bugzilla.kernel.org/attachment.cgi?id=285813 Kernel 5.4-rc6 config for the Cyrus+ board and for the QEMU ppce500 board (CPU: P5040 and P5020): https://bugzilla.kernel.org/attachment.cgi?id=285815 Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=205201 Thanks for your help, Christian