Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp738570ybx; Thu, 7 Nov 2019 01:55:43 -0800 (PST) X-Google-Smtp-Source: APXvYqxYj7o9PBLdvaK/rb2VwtHOZU/8gWZMvgm9lK/87vM1x/WaDwPicRs2hF1q3Ue/lNAjCamT X-Received: by 2002:a17:906:4e55:: with SMTP id g21mr2194681ejw.0.1573120543856; Thu, 07 Nov 2019 01:55:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573120543; cv=none; d=google.com; s=arc-20160816; b=a3c4o6x05DYDiDriVYZ2AlJ4MVP792VRlJiXjJYSvXtTomlXJCbt9f/e4YtSNZIvjU tMpsTyheERkWzO5oNqH+LLzzelueaoPiQofEwhh4jcDODRJrCFEXzKID//8fcCMbGVmm fv1Ws6mLrNDFLTFFuTqzr6DpiVPwA6wb1/8OGm5UMqHbazInRBC+M6X5vOsjZRLWjIyx kC/zBRGUJXiteMirsT3kdJzPFiKqhva8rjFTtXmFZxDh4RlHw8TEOE65CAmo/VXzUgkD wwod7ym8ddCJafxTU8G4aJodEUJmjCVmF55nE/M9DleYQ+QeDQlRGWWPDzsuEPohDv2X oNkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:to:from:subject:message-id; bh=9QLm+BfTSAz3hvmEGD2lKD1JPhPsyFj2znOWPA92kPw=; b=xRm+JcAJ8xyhf/AZaIKs4J/U0dY83sldRSYWHWMqwzw1R661v8vK92ggDMnAeaHBBa DvBaD+mCgBXATN+5EBZjQD+k0nlnB1peHFEhXOo5bO/ISFJQWkEtknG6BB6kgHSfWa+Y ruvW4eih+Nyd/1ZBinEQ7vhv5OBTKRboYX+27o9KFtGzhuYacAEO1EY1U8uD8TEqZOru Tx7zDdxW5MlEoCtQQVElhbWL8XHnZ3GHd/dmZsOoybJAxh+JT4hiQqRuRVAkzc3e7pJc 3HTIn4CzTxxNAiOl+B5EgudEdZRmMZ2fdq+LeOqME5ntJC/5araXO4DcfarFAw9Y94nh OJlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f29si1124855ejj.110.2019.11.07.01.55.20; Thu, 07 Nov 2019 01:55:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387918AbfKGJyi (ORCPT + 99 others); Thu, 7 Nov 2019 04:54:38 -0500 Received: from smtprelay0130.hostedemail.com ([216.40.44.130]:59943 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726734AbfKGJyi (ORCPT ); Thu, 7 Nov 2019 04:54:38 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id F0F76182CED34; Thu, 7 Nov 2019 09:54:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 13,1.2,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1381:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3870:3871:3872:3873:3874:4321:5007:6119:6691:7903:10008:10400:10848:11026:11232:11473:11657:11658:11914:12043:12048:12049:12296:12297:12438:12740:12760:12895:13019:13069:13095:13161:13229:13311:13357:13439:14659:14721:21080:21433:21627:30029:30054:30091,0,RBL:47.151.135.224:@perches.com:.lbl8.mailshell.net-62.8.0.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:1:0,LFtime:25,LUA_SUMMARY:none X-HE-Tag: ring31_45311ab5a8d41 X-Filterd-Recvd-Size: 1775 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf20.hostedemail.com (Postfix) with ESMTPA; Thu, 7 Nov 2019 09:54:35 +0000 (UTC) Message-ID: <4c74db2614cefe23f888d0643c2d7c356086745a.camel@perches.com> Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output From: Joe Perches To: Wambui Karuga , hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 07 Nov 2019 01:54:22 -0800 In-Reply-To: <20191107092945.15513-1-wambui.karugax@gmail.com> References: <20191107092945.15513-1-wambui.karugax@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > Replace the use of the dev_err macro with the DRM_DEV_ERROR > DRM helper macro. The commit message should show the reason _why_ you are doing this instead of just stating that you are doing this. It's not that dev_err is uncommon in drivers/gpu/drm. $ git grep -w dev_err drivers/gpu/drm | wc -l 1950 $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l 756 > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c [] > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > } > > if (!dsi->cdata) { > - dev_err(dev, "no dsi-config for %s node\n", np->name); > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > return -EINVAL; > }