Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Nov 2019 01:55:54 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Amol Grover <frextrite@gmail.com>
Cc:     Phong Tran <tranmanphong@gmail.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, rcu@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] Documentation: RCU: rcubarrier:
 Convert to reST
Message-ID: <20191107095553.GM20975@paulmck-ThinkPad-P72>
Reply-To: paulmck@kernel.org
References: <20191106165617.GA12205@workstation-kernel-dev>
 <15512469-fc7e-24c8-d407-72ba7015a099@gmail.com>
 <20191107063949.GA2310@workstation-kernel-dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191107063949.GA2310@workstation-kernel-dev>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 07, 2019 at 12:09:49PM +0530, Amol Grover wrote:
> On Thu, Nov 07, 2019 at 07:19:27AM +0700, Phong Tran wrote:
> > On 11/6/19 11:56 PM, Amol Grover wrote:

[ . . . ]

> > >   We instead need the rcu_barrier() primitive.  Rather than waiting for
> > >   a grace period to elapse, rcu_barrier() waits for all outstanding RCU
> > > -callbacks to complete.  Please note that rcu_barrier() does -not- imply
> > > +callbacks to complete.  Please note that rcu_barrier() does **not** imply
> > >   synchronize_rcu(), in particular, if there are no RCU callbacks queued
> > >   anywhere, rcu_barrier() is within its rights to return immediately,
> > >   without waiting for a grace period to elapse.
> > > @@ -89,78 +94,78 @@ module uses multiple flavors of call_rcu(), then it must also use multiple
> > >   flavors of rcu_barrier() when unloading that module.  For example, if
> > >   it uses call_rcu(), call_srcu() on srcu_struct_1, and call_srcu() on
> > >   srcu_struct_2(), then the following three lines of code will be required
> > 
> > Hello Amol,
> > 
> > srcu_struct_2() should be srcu_struct_2
> 
> Hey Phong,
> Thanks for the review! Fixed and sent the new patch
> https://lore.kernel.org/lkml/20191107063241.GA2234@workstation-kernel-dev/

Phong, please let us know whether Amol's new version looks good to you.
If it does, preferably with your Reviewed-by and/or Tested by.  ;-)

							Thanx, Paul