Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Nov 2019 18:20:29 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org,
        Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH v2] perf tests: Fix out of bounds memory access
Message-ID: <20191107102029.GA32679@leoy-ThinkPad-X240s>
References: <20191107020244.2427-1-leo.yan@linaro.org>
 <20191107094226.GC14657@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191107094226.GC14657@krava>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 07, 2019 at 10:42:26AM +0100, Jiri Olsa wrote:

[...]

> > To fix this issue, we will use evlist__open() and evlist__close() pair
> > functions to prepare and cleanup context for evlist; so 'evsel->id' and
> > 'evsel->ids' can be initialized properly when invoke do_test() and avoid
> > the out of bounds memory access.
> 
> right, we need to solve this on libperf level, so it's possible
> to call mmap/munmap multiple time without close/open.. I'll try
> to send something, but meanwhile this is good workaround
> 
> Reviewed-by: Jiri Olsa <jolsa@kernel.org>

Thanks for reviewing, Jiri.

You are welcome to send us the fixing patches, I am glad to test it on
qemu_arm.

Thanks,
Leo Yan