Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1573126365.3024.4.camel@suse.com>
Subject: Re: [PATCH 4.19 114/149] UAS: Revert commit 3ae62a42090f ("UAS: fix
 alignment of scatter/gather segments")
From:   Oliver Neukum <oneukum@suse.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Alan Stern <stern@rowland.harvard.edu>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>
Date:   Thu, 07 Nov 2019 12:32:45 +0100
In-Reply-To: <20191105163805.GB2760793@kroah.com>
References: <Pine.LNX.4.44L0.1911051007140.1678-100000@iolanthe.rowland.org>
         <1572968467.2921.27.camel@suse.com> <20191105163805.GB2760793@kroah.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am Dienstag, den 05.11.2019, 17:38 +0100 schrieb Greg Kroah-Hartman:
> > > Given this information, perhaps you will decide that the revert is 
> > > worthwhile.
> > 
> > Damned if I do, damned if I do not.
> > Check for usbip and special case it?
> 
> We should be able to do that in the host controller driver for usbip,
> right?  What is the symptom if you use a UAS device with usbip and this
> commit?

Yes, that patch should then also be applied. Then it will work.
Without it, commands will fail, as transfers will end prematurely.

	Regards
		Oliver