Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp903772ybx; Thu, 7 Nov 2019 04:26:34 -0800 (PST) X-Google-Smtp-Source: APXvYqynOY7O6biXpdlj/2LOpwOPWOKTp7ctiso0aB6uwZbBjaKQMXe9eVjweDuYC7lArfqJTd5/ X-Received: by 2002:a17:906:2961:: with SMTP id x1mr2711912ejd.91.1573129594375; Thu, 07 Nov 2019 04:26:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573129594; cv=none; d=google.com; s=arc-20160816; b=BzxUJJSCTOzoE6YQEg9wll3QRCUjlT/7/Cvhv05EqmavcQUtIehYP+S+lorJ/yLLOi cXLAieeyq2AtXxrbvyYyF5ovyaL+ZNzqvIiXJQi2jRkIzc8Hc0/LHMnopqTDNLmxd1Kf 89P8ry92U7fPO0b6c3YOnmuBvgumzJXkDB0Egagqt3tdxa9bjTgMDJL4efliKK8KyGjx DOVFcNlERsglxGhmkgdI60PDLWOiY8/C0VHZPgsOi2o9esZBD9Y3T61ysA7LeY91fVQK mNPKblXCYP8SEo4cO/tLB13OgS1ajIH2Uuol2/jleWYdroLCUWmSgObMPssn/8jI/rdQ rayg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=u1D/jMUPBggm7fKyOw8z+Z0IZWc9etepWNLlodOjDWo=; b=d7NAVu8QiUY6ta+znhJ6bn7oEGZiy5d5Etpm8Ra6KF27H3VOHCDngGknzAt4vd51lp HcZrtpxurSYFwMr+h3R02hvVgSBhjdzBIb7LDNeqS4OrHK3hffHemaMI6178a4wKTsQW 65W5vLEhS7tZCzP1WpQbTa+xKRNl5h+QCL9O9SWSE4ithFsxeYOMe2mrPaMeKOxp4QQX nlWUUzqA+lhbLPxNNBHFzBT7xR0MFgCUIDeg0kBoQZJ5Wup4qOhm7GDyobMqUceZyLtq GlIK7pdCvPQP5EgbrX0GjgrbunJpZGaT+6zKNu0v02wDrFoswd0w/5DmgeBBdn7hFBwi inJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=b6yYq+8M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k14si1294515ejj.388.2019.11.07.04.26.10; Thu, 07 Nov 2019 04:26:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=b6yYq+8M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388206AbfKGMVV (ORCPT + 99 others); Thu, 7 Nov 2019 07:21:21 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:35083 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbfKGMVU (ORCPT ); Thu, 7 Nov 2019 07:21:20 -0500 Received: by mail-lf1-f67.google.com with SMTP id y6so1452331lfj.2 for ; Thu, 07 Nov 2019 04:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u1D/jMUPBggm7fKyOw8z+Z0IZWc9etepWNLlodOjDWo=; b=b6yYq+8MUVaj25CBZlpZHQ/DP8sDzm+IMMu+r01ltxON5VGSKcn5JWC4Xyr6diA/ms pFbRqFX1FIpEv5r34PRAJbdeakoIaYN+cvJBKwgUOhlKQNBYNK+C5QM3ou/maSITDOkg bo5oryduhQTU6OKzYsmmU8q/CkUMTLl6QiR8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u1D/jMUPBggm7fKyOw8z+Z0IZWc9etepWNLlodOjDWo=; b=RnfgTljIa+vzuvQ3hXbL805gvifV5A1uFoaT2OdV6VI3rbY502qfPMqyoXnbfB79/z nlEZ/YMlyrHjJegbiUy4E9X8vjyI6Nlha6eamy2l4cYXTtVwIGpd1gUQ1/0eok/Zzu8j sNRMy5iuWElF3dDeoP3blRNByMS+UfBckW0CnFtBPCbWKB1OISMq0YfBcQjXlm7OGuCZ 6iLNDPL+9zAzQB4EzgwxEU4jbHiIZo7L6El3MrJvSqqKO7Px08IdlYGA8MV27rxV6owW JS9qMINxEwwButPWg6pLCDE/Qh3UU0YLHuacS0M9I2dZiXcZXYYpRp4PMMlzrnuk5JA7 PGhg== X-Gm-Message-State: APjAAAUTZ6EbS4YhF9ayIWLSgNg1MXPpcqdnl9UadDqftjLARr+FQmDS M7tQvCrNp3XMSHb4HbAyMLrt5Q== X-Received: by 2002:ac2:5195:: with SMTP id u21mr2189413lfi.97.1573129278458; Thu, 07 Nov 2019 04:21:18 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id x1sm1937325lff.90.2019.11.07.04.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 04:21:17 -0800 (PST) From: Rasmus Villemoes To: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Mark Rutland Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kurt Kanzenbach Subject: [PATCH v7 0/2] Add support for Layerscape external interrupt lines Date: Thu, 7 Nov 2019 13:21:13 +0100 Message-Id: <20191107122115.6244-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In v7, I've tried to change from a custom binding to use interrupt-map, modelled on the recent addition of the renesas,rza1-irqc (commits a644ccb819bc and 5e27a314a11f). It's possible that the interrupt-map parsing code can be factored to a common helper, but it's a bit hard to generalize from two examples to know what a good interface would look like. The interrupt-map-mask is a bit arbitrary. 0xff would likely work just as well (but I think the ls2088a has 32 external lines, so it has to be a least 0x1f). Also, this drops the fsl,bit-reverse property and instead reads the SCFGREVCR register to determine if bit-reversing is needed. The dt/bindings patch now comes first in accordance with Documentation/devicetree/bindings/submitting-patches.txt. Earlier versions can be found here: v6: https://lore.kernel.org/lkml/20190923101513.32719-1-kurt@linutronix.de/ v5: https://lore.kernel.org/lkml/20180223210901.23480-1-rasmus.villemoes@prevas.dk/ Rasmus Villemoes (2): dt/bindings: Add bindings for Layerscape external irqs irqchip: add support for Layerscape external interrupt lines .../interrupt-controller/fsl,ls-extirq.txt | 49 +++++ drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-ls-extirq.c | 197 ++++++++++++++++++ 4 files changed, 251 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.txt create mode 100644 drivers/irqchip/irq-ls-extirq.c -- 2.23.0