Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1bacac547977493e50bb1fadfaf4b9ad5b4fdf0c.camel@pengutronix.de>
Subject: Re: [PATCH v5 0/3] reset: npcm: add NPCM reset driver support
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Tomer Maimon <tmaimon77@gmail.com>, robh+dt@kernel.org,
        mark.rutland@arm.com, yuenn@google.com, venture@google.com,
        benjaminfair@google.com, avifishman70@gmail.com, joel@jms.id.au
Cc:     openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Date:   Thu, 07 Nov 2019 13:59:32 +0100
In-Reply-To: <20191106145331.25740-1-tmaimon77@gmail.com>
References: <20191106145331.25740-1-tmaimon77@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tomer,

On Wed, 2019-11-06 at 16:53 +0200, Tomer Maimon wrote:
> This patch set adds reset controller support 
> for the Nuvoton NPCM Baseboard Management Controller (BMC).
> 
> Apart of controlling all NPCM BMC reset module lines the NPCM reset driver
> support NPCM BMC software reset to restarting the NPCM BMC.
> 
> Supporting NPCM USB-PHY reset as follow:
> 
> NPCM BMC USB-PHY connected to two modules USB device (UDC) and USB host.
> 
> If we will restart the USB-PHY at the UDC probe and later the 
> USB host probe will restart USB-PHY again it will disable the UDC
> and vice versa.
> 
> The solution is to reset the USB-PHY at the reset probe stage before 
> the UDC and the USB host are initializing.
> 
> NPCM reset driver tested on NPCM750 evaluation board.
> 
> Addressed comments from:.
>  - Philipp Zabel
> 
> Changes since version 4:
>  - Check for stored GCR string in the of_device_id->data to gain
>    GCR regmap access. 
>  - Adding check if the user used undefined reset pins
>    in the of_xlate function.
>  - Remove nr_resets initialization since it of_xlate replaced 
>    with the custom version.

Thanks, all three applied to reset/next with Rob's R-b.

regards
Philipp