From: Keith Owens <kaos@sgi.com>
To: paulmck@us.ibm.com
cc: John Hesterberg <jh@sgi.com>, Matt Helsley <matthltc@us.ibm.com>,
       Jes Sorensen <jes@trained-monkey.org>,
       Shailabh Nagar <nagar@watson.ibm.com>, Andrew Morton <akpm@osdl.org>,
       Jay Lan <jlan@engr.sgi.com>, LKML <linux-kernel@vger.kernel.org>,
       elsa-devel@lists.sourceforge.net, lse-tech@lists.sourceforge.net,
       CKRM-Tech <ckrm-tech@lists.sourceforge.net>, Paul Jackson <pj@sgi.com>,
       Erik Jacobson <erikj@sgi.com>, Jack Steiner <steiner@sgi.com>
Subject: Re: [Lse-tech] Re: [ckrm-tech] Re: [PATCH 00/01] Move Exit Connectors 
In-reply-to: Your message of "Wed, 11 Jan 2006 22:51:15 -0800."
             <20060112065115.GB23673@us.ibm.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 12 Jan 2006 18:50:34 +1100
Message-ID: <19140.1137052234@kao2.melbourne.sgi.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 903
Lines: 20

"Paul E. McKenney" (on Wed, 11 Jan 2006 22:51:15 -0800) wrote:
>On Thu, Jan 12, 2006 at 05:19:01PM +1100, Keith Owens wrote:
>> OK, I have thought about it and ...
>> 
>>   notifier_call_chain_lockfree() must be called with preempt disabled.
>> 
>Fair enough!  A comment, perhaps?  In a former life I would have also
>demanded debug code to verify that preemption/interrupts/whatever were
>actually disabled, given the very subtle nature of any resulting bugs...

Comment - OK.  Debug code is not required, the reference to
smp_processor_id() already does all the debug checks that
notifier_call_chain_lockfree() needs.  CONFIG_PREEMPT_DEBUG is your
friend.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/