Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jean-Baptiste Maneyrol <JManeyrol@invensense.com>
To:     Stephan Gerhold <stephan@gerhold.net>
CC:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Brian Masney <masneyb@onstation.org>,
        Jonathan Marek <jonathan@marek.ca>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] iio: imu: mpu6050: Add support for vdd-supply
 regulator
Thread-Topic: [PATCH 2/2] iio: imu: mpu6050: Add support for vdd-supply
 regulator
Thread-Index: AQHVlNFPtLyzEyio0k+Y+ApC2k58Gqd+jQakgAAdxwCAAQpE1A==
Date:   Thu, 7 Nov 2019 13:29:33 +0000
Message-ID: <MN2PR12MB3373846E85AA1A396198F46EC4780@MN2PR12MB3373.namprd12.prod.outlook.com>
References: <20191106183536.123070-1-stephan@gerhold.net>
 <20191106183536.123070-2-stephan@gerhold.net>
 <MN2PR12MB3373CA676226F02BE0C804A8C4790@MN2PR12MB3373.namprd12.prod.outlook.com>,<20191106213359.GA130672@gerhold.net>
In-Reply-To: <20191106213359.GA130672@gerhold.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: invensense.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e66ed96c-8da1-4a15-0593-08d7638686ef
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 13:29:33.5114
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 462b3b3b-e42b-47ea-801a-f1581aac892d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XtES9Gdf/ghCmm58rSF/kICpk3shLEsMMXt1ul8y3U3ZbCu94YULqyYDzBxV+gBoZdtzwQOtss6kzMkDMKU4UPTjVu3YOrnyhFFTIktB/nU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3917
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572
 definitions=2019-11-07_04:2019-11-07,2019-11-07 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 bulkscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 priorityscore=1501
 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 clxscore=1015
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1910280000 definitions=main-1911070135
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 Hi Stephan,=0A=
=0A=
I think the regulator_bulk usage is good, and the core_enable/disable_regul=
ator functions implemented the way you did is perfect for the init/shutdown=
 phase.=0A=
=0A=
We just need to change the suspend/resume implementation to use something d=
ifferent.=0A=
=0A=
Thanks,=0A=
JB=0A=
=0A=
=0A=
From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> on =
behalf of Stephan Gerhold <stephan@gerhold.net>=0A=
=0A=
Sent: Wednesday, November 6, 2019 22:36=0A=
=0A=
To: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>=0A=
=0A=
Cc: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack <knaack.h@gmx.de>; =
Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw=
.net>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com=
>; Linus Walleij <linus.walleij@linaro.org>;=0A=
 Brian Masney <masneyb@onstation.org>; Jonathan Marek <jonathan@marek.ca>; =
linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; devicetree@vger.kern=
el.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-ke=
rnel@vger.kernel.org>=0A=
=0A=
Subject: Re: [PATCH 2/2] iio: imu: mpu6050: Add support for vdd-supply regu=
lator=0A=
=0A=
=A0=0A=
=0A=
=0A=
=A0CAUTION: This email originated from outside of the organization. Please =
make sure the sender is who they say they are and do not click links or ope=
n attachments unless you recognize the sender and know the content is safe.=
=0A=
=0A=
=0A=
=0A=
Hi JB,=0A=
=0A=
=0A=
=0A=
On Wed, Nov 06, 2019 at 07:55:20PM +0000, Jean-Baptiste Maneyrol wrote:=0A=
=0A=
> Hello Stephan,=0A=
=0A=
> =0A=
=0A=
> nice patch but I have an important concern.=0A=
=0A=
> =0A=
=0A=
> We are calling the core_enable/disable_regulator functions when going int=
o suspend and resume.=0A=
=0A=
> With your changes, we are going to power down the chip when going into su=
spend and then power it up again.=0A=
=0A=
> This way we will loose all already set configuration, like FSR, sampling =
rate, init values, ...=0A=
=0A=
> The chip will not be able to work correctly anymore after a suspend-resum=
e cycle.=0A=
=0A=
> =0A=
=0A=
> You need to change the resume/suspend handlers to only disable/enable the=
 vddio regulator, not the vdd one.=0A=
=0A=
=0A=
=0A=
That is a good point, thanks!=0A=
=0A=
I guess we are not able to use the regulator bulk API in this case...=0A=
=0A=
=0A=
=0A=
I will send a v2 soon.=0A=
=0A=
=0A=
=0A=
Stephan=0A=
=0A=