Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750932AbWALJHQ (ORCPT ); Thu, 12 Jan 2006 04:07:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751380AbWALJHQ (ORCPT ); Thu, 12 Jan 2006 04:07:16 -0500 Received: from styx.suse.cz ([82.119.242.94]:49832 "EHLO mail.suse.cz") by vger.kernel.org with ESMTP id S1750932AbWALJHP (ORCPT ); Thu, 12 Jan 2006 04:07:15 -0500 Date: Thu, 12 Jan 2006 10:07:33 +0100 From: Vojtech Pavlik To: Benjamin Herrenschmidt Cc: Michael Hanselmann , dtor_core@ameritech.net, linux-kernel@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz, linuxppc-dev@ozlabs.org, linux-kernel@killerfox.forkbomb.ch Subject: Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks Message-ID: <20060112090733.GA7627@midnight.suse.cz> References: <20051225212041.GA6094@hansmi.ch> <200512252304.32830.dtor_core@ameritech.net> <1135575997.14160.4.camel@localhost.localdomain> <20060111232651.GI6617@hansmi.ch> <1137022900.5138.66.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1137022900.5138.66.camel@localhost.localdomain> X-Bounce-Cookie: It's a lemon tree, dear Watson! User-Agent: Mutt/1.5.10i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 51 On Thu, Jan 12, 2006 at 10:41:40AM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2006-01-12 at 00:26 +0100, Michael Hanselmann wrote: > > > * This is the global environment of the parser. This information is > > @@ -431,6 +433,14 @@ struct hid_device { /* device repo > > void (*ff_exit)(struct hid_device*); /* Called by hid_exit_ff(hid) */ > > int (*ff_event)(struct hid_device *hid, struct input_dev *input, > > unsigned int type, unsigned int code, int value); > > + > > +#ifdef CONFIG_USB_HIDINPUT_POWERBOOK > > + /* We do this here because it's only relevant for the > > + * USB devices, not for all input_dev's. > > + */ > > + unsigned long pb_fn[NBITS(KEY_MAX)]; > > + unsigned long pb_numlock[NBITS(KEY_MAX)]; > > +#endif > > }; > > I don't understand the comment above ? You are adding this to all struct > hid_device ? There can be only one of those keyboards plugged at one > point in time, I don't think there is any problem having the above > static in the driver rather than in the hid_device structure. I think having it in struct hid_device is safer. We might want to dynamically allocate only for PowerBook keyboards, though, to save memory. > > .../... > > > > > + if ((hid->quirks & HID_QUIRK_POWERBOOK_HAS_FN) && > > + hidinput_pb_event(hid, input, usage, value)) { > > + return; > > + } > > + > > Dimitry might disagree but it's generally considered bad taste to have > { and } for a single statement :) I do agree, though. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/