Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1135243ybx; Thu, 7 Nov 2019 07:47:18 -0800 (PST) X-Google-Smtp-Source: APXvYqxKg40S8tSx4fmOYQMB8lK4GrjYXDRTOKm7l3Jd+eAzJ2S6jXrDs+KIn80aPiHxjCcYhqEb X-Received: by 2002:a17:906:2615:: with SMTP id h21mr3729931ejc.212.1573141638416; Thu, 07 Nov 2019 07:47:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573141638; cv=none; d=google.com; s=arc-20160816; b=o8x5squho7hBobbcvxJoP+dydziOVeU5UHAPDBtqMschueYhM18bMMJ2/NP03gO1ft HcOK5liHveaXot9t9CWH3lHU6rdjTl2JbFgLQz6VxYFoEwLxwxAEa12eLxKcjBF4aOQo 1D0Xd6pxmeRB5Sq8GDdIEFqC7NUpo0zfjLSyLTFio7eWzz3EnK0EWQVAcSCODvJ+FWBv YliQrI1s7WW9T/ZxUAa2f+wqRhO5P8ysEJVBwH2M+oge0Q31NWSepR1RERzQRPpi7Y/9 hkoYjYBNpVVb3PfHG7CIVHNLUHH0bB5AetVizTRTVah7MoBiR6if/UtdTIQ3IJ4DUonj 5tcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=mwaiGtvP4pjM/nFFuK45HtDQzJ+7MTmhsD7fO3UNaLE=; b=tMvT45tkf60rHbamMPSWZ9maHo/JIrDE7QyjFuey5OuJrBSSbmo4MoTL37PsbX1jqt 49B6n9uaxTQHVG1T30IA5+jXB8vzzC1sHhBcZ5axSZBulF7wm5bQcyw6L+FaHivO96TX O0Wd4W8eneD2lLyfzJdaizLdYzA+bSDrg4I54At4brdxm6DeGzryv6DGKXXHRVLCbtmZ z1ZuR7VBpCadm7MIeDUrlmVJcilClT1jmWHD/kYOf+hP3GvThW+mt770PAqSJN+YBTMO rJ5teEoUx43xbV2kbzx3nlbzpASC9AZRCzzrnmwxtVClfGcqogBlPHTUeIG9NUZZRzD4 wC1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=rTdt1J+G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x28si1708825edd.427.2019.11.07.07.46.55; Thu, 07 Nov 2019 07:47:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=rTdt1J+G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388230AbfKGPnq (ORCPT + 99 others); Thu, 7 Nov 2019 10:43:46 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:38986 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbfKGPnq (ORCPT ); Thu, 7 Nov 2019 10:43:46 -0500 Received: by mail-qt1-f193.google.com with SMTP id t8so2851454qtc.6; Thu, 07 Nov 2019 07:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mwaiGtvP4pjM/nFFuK45HtDQzJ+7MTmhsD7fO3UNaLE=; b=rTdt1J+GEp1asFTQuPZVLcym1i5w0oDHdqK+9eXSBrJuj7tdWm6FUF8DlfmazZtYqO ghii+a6FoGSHFZg7Ys67K5plupUG3MZvxdDcnM61T2Z+XSu3/paB3f2akk4aCTK0cbRi 7CWFxtSTtTLVzrgtNS9/g1A5TgCMrdM4OOEdsz4V5l7iS35AnyfsaQBFFo4lnnnP6UYu 0j+GZmDCRxHFSj7hYHPU6DydmhEF6Yo72kZruft0BxB/Xl2jgVur26PTpGZ/8OdK1nAI 9koLUWef6/HPzFUSIEKrgh46voUNO8YEWWCvNlAZxxVvyvE5IZDvc9t+F1VACtj4fj9e 8rPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mwaiGtvP4pjM/nFFuK45HtDQzJ+7MTmhsD7fO3UNaLE=; b=MMqKn7+ALEfY4HBsxk0mJ89UUYOadPQbBcXoMzxhhVHErKu7qLJtF7K7YOX0wj1Dnz sf90s5cyZh1F37JgtOWjEFqSgv+tLXdiZHi6AGRfaLVrBKkVyN1E0sj/z10Zfk1bx/R0 AmnThrOuLmJhF70mhs2vq0Z0187Gl2uky5vW7mGspcrmtBqxJhfnUzwkX4Pv/g56NoS9 jZJlMDRN2k4ye5Z8r98dS7WHZ+tg7RMsDT0l9ZTaZOUOQBVWshKaK6DwMcl5rp94q97L 2TR43ifUeQ/F0F7M2Ex5ffKig3XGUty7Cp0JlJ7TaDORyYyW2bie0yOhxsjngJQPBNG4 W9lg== X-Gm-Message-State: APjAAAVRi91zwiLr52azi7qk+51S6OkVM1mzFWQPx9Uyo43oeQDsY+f9 j+M00CphfrXQji0nSnY26AI= X-Received: by 2002:ac8:3a21:: with SMTP id w30mr4498647qte.299.1573141424023; Thu, 07 Nov 2019 07:43:44 -0800 (PST) Received: from localhost ([2620:10d:c091:500::2:3f13]) by smtp.gmail.com with ESMTPSA id f24sm1147320qkh.81.2019.11.07.07.43.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Nov 2019 07:43:43 -0800 (PST) Date: Thu, 7 Nov 2019 07:43:41 -0800 From: Tejun Heo To: Michal Hocko Cc: Roman Gushchin , linux-mm@kvack.org, Andrew Morton , Johannes Weiner , linux-kernel@vger.kernel.org, kernel-team@fb.com, stable@vger.kernel.org Subject: Re: [PATCH 1/2] mm: memcg: switch to css_tryget() in get_mem_cgroup_from_mm() Message-ID: <20191107154341.GX3622521@devbig004.ftw2.facebook.com> References: <20191106225131.3543616-1-guro@fb.com> <20191107122125.GS8314@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107122125.GS8314@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Nov 07, 2019 at 01:21:25PM +0100, Michal Hocko wrote: > Hmm, how can we have a task in an offline memcg? I thought that any > existing task will prevent cgroup removal from proceeding. Is this some > sort of race where the task managed to disassociate from the cgroup > while there is still a binding to a memcg existing? What am I missing? The previous cgroup one was from bsd process accounting which happens after the process is marked head. This one IIUC is from core dumping path. Thanks. -- tejun