Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1215258ybx; Thu, 7 Nov 2019 08:52:42 -0800 (PST) X-Google-Smtp-Source: APXvYqxqYYeLY9mPJGR8sX21P29J/prFS1q6rQRVGrsSF0hxEKTChAq7wLdf3fijVM3W8C0qYI/T X-Received: by 2002:a50:eb8b:: with SMTP id y11mr4805674edr.242.1573145562303; Thu, 07 Nov 2019 08:52:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573145562; cv=none; d=google.com; s=arc-20160816; b=H8TkhA4GUslQWtaya1f3+evyFXJooYCOP7fUJfZO5iiCzn1KJtB6Qh9AoT17Z3sMri nOSM7wFSIKEUlCuq3FIB1Sc9FHkvRqrnrdwyGuVlNlz0aYBY0bkvcv4JufdTXsze10se OM8sJ5rYUF8baVOQ2yQeOBM5A1sFvpWgKx6laTjt6uIcRevHTZZUC+rrFHjrrsv+vOkG a6V7eGo3/TEQ40F7+LDkiTU3rp+yv0aJwWfDG8IrjQFHeNoQxSDZjUZ7OLv4+e4bXcRV nmCd4vnfK6DkwGF2EkTQvLAQqZ3E/LxjMDhOrxPJ1sWk9X7txju3AHitbvcNu9Cr6dkm LEig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jYTfSV1oZeUJYZU4gfOF6jyruHNySGC3SVu8cJZAaKM=; b=ivUxMmPGIgxo4OLzFDPC8lMx1oZlUfut6d7UV/FWz6Qgb8NFt6w2+FXR98BOT/WnVX Y0Dhx04jLDReo+HsREy7O99J1GC4MEksvgGvUCwXfswqXHurOi3aMA/ZLXyH0TA2d45b hlebodDlYFrmCcKvD596HG6YVhPZbyS+6PC8RfdfWvZZJs8IMuAb4s/pO/PtTlgz5EnT GdVHb+dTes1yvwRQ+SYsGdkWwnNm3xhIxSg7UJcnCaZ7bVgv2Ul6O/vJ3GFaS3PytFsn 2WP2lOKg+OHbxucqXmvXd4hl21Qujz+Ig0CS73wulkpaKr+9HL1gCRFE4WYNCWJvV+v3 Gpbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FDTQzL5N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b30si1842170edc.320.2019.11.07.08.52.18; Thu, 07 Nov 2019 08:52:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FDTQzL5N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730525AbfKGQvE (ORCPT + 99 others); Thu, 7 Nov 2019 11:51:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:49466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726810AbfKGQvD (ORCPT ); Thu, 7 Nov 2019 11:51:03 -0500 Received: from localhost (unknown [106.51.111.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2ABD72085B; Thu, 7 Nov 2019 16:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573145463; bh=vhtukU2oNC7F9Y1HZ3CqDAbYwg3qJkSQKGQ29ol4x9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FDTQzL5NOSTc7jRISFLiIvMs5drUHQ+k39Otyc2CdSWaahz0yjBr8r8S1HOpFGGSl FgCsaYpvxRqXN/9hogGZGnHjUHFjyOlbnUu/0pP8BnHlnjjJX074mbdUjeyQpgnWuE ITt2n9Wi/0PSK04aF56cQWkC0lnkE+Y25wWso6jY= Date: Thu, 7 Nov 2019 22:20:58 +0530 From: Vinod Koul To: Elliot Berman Cc: bjorn.andersson@linaro.org, saiprakash.ranjan@codeaurora.org, agross@kernel.org, tsoni@codeaurora.org, sidgup@codeaurora.org, psodagud@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/17] firmware: qcom_scm: Order functions, definitions by service/command Message-ID: <20191107165058.GP952516@vkoul-mobl> References: <1572917256-24205-1-git-send-email-eberman@codeaurora.org> <1572917256-24205-4-git-send-email-eberman@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572917256-24205-4-git-send-email-eberman@codeaurora.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04-11-19, 17:27, Elliot Berman wrote: > Definitions throughout qcom_scm are loosely grouped and loosely ordered. > Sort all the functions/definitions by service ID/command ID to improve > sanity when needing to add new functionality to this driver. Reviewed-by: Vinod Koul -- ~Vinod