Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1497207ybx; Thu, 7 Nov 2019 12:43:33 -0800 (PST) X-Google-Smtp-Source: APXvYqyIVygFm+Swv0nSYWLXo7Z6vU47V1ZL9jIfNp7+7NgqQ9OG0tshPlphHud5D1/hcQcK3Kod X-Received: by 2002:aa7:cb18:: with SMTP id s24mr6003533edt.281.1573159413738; Thu, 07 Nov 2019 12:43:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573159413; cv=none; d=google.com; s=arc-20160816; b=qATGXpm6TlV+G11F/QKa4fwebjCiWB1Wb4WXksVo2EK09TMbYm9mAWCrKhwGy+SUfQ GKKOhNwzsJ3MITUvtBFTc8LbahN66G96EcwrNsXS0yTySsuSTWAph8vLMchg/JG1Zc/V 36OTSjBHutqaHl8i6483eetBFfjOXIb6SMas7mxBRq7u1RlAVpfirUZonahyPaID0nn9 wOik1c6LBa+lk9/WMgxP9nCSXoLM2UqnPbSX3O3pDDcU3d3Xy/+UDc1N66oLktScVQa1 Tt4sp5OI2NNwisUW4C2qrAYEK0KhMxrZm2vt6tUZyh37kKpyD3DVOear2sLkB+PY/dnS ny+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=/pKH0tT7IUWPxlqReLKSDJjr+ZKqHoHFlpAU48nDsb8=; b=kddm0wNhzhWn+lO0KnHYIUgbqf9wdxhlZx5YOQR09hDmGiuP2dJYaNsO4Uim9QAQKm Nx6jS6wC+7N9W2GAhcHf5gAfnduC51MUcKK9FN5WbNXHkeYeZ+brnRhTO01c8H57lHI+ I3lID57cOAlSW+IYtZARovQ4ED7mg4aMo+9icn6RQoyzewflbaDsI2yY6wLk86WLL+/T APXJ7ymLlmf5dbHcQfvmPDPgW0OYz5K828pNp+uUDQeOegSLKCashv9egwxy4t/hXoKX 9lFkXzT89laXp1EBe1ydKF9CW90GJBDI4q9ZiKPQSEYHESSbkeBKv/91i9NxZQ+2hmpt 5iAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=YJruocL3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o22si2148309eja.122.2019.11.07.12.43.08; Thu, 07 Nov 2019 12:43:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=YJruocL3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726295AbfKGUkY (ORCPT + 99 others); Thu, 7 Nov 2019 15:40:24 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36524 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfKGUkX (ORCPT ); Thu, 7 Nov 2019 15:40:23 -0500 Received: by mail-wm1-f66.google.com with SMTP id c22so4002186wmd.1 for ; Thu, 07 Nov 2019 12:40:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/pKH0tT7IUWPxlqReLKSDJjr+ZKqHoHFlpAU48nDsb8=; b=YJruocL3WMHsSdrAyY52mp704CIZlMgZTUFDzjAsr0YlHFddlJA0cTV1nlVZRLwFHb jUQfYrr/sRxB7PFJ4W08gutrX2v/Clmr3WpGEORKeKLuxqF/cVtZOoi5Mfq+Jc/5psVV SSBjEKQVrwI9IptIxB6HyM5eXh9id07j8C7r8KeprTTreRrvLqAK/qRzRmIsoetJ9xKG FP4C2TdMB62F4KwRRzxluS4yXYRAuFR77Xp5SAmlgh9SPA9/lrDbeT4PhAK0N9Mn4Udl C4lx+IzKQiOfy+WDLgquCQEJN5AAJFuuv62ZVkLB6DnuKLCNe/wDVDtIB8hUJASWVtal +1mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/pKH0tT7IUWPxlqReLKSDJjr+ZKqHoHFlpAU48nDsb8=; b=KSwTucXStbg/WNH2SAtuTccxD8GoO6y0zvR8cut4xENQRWn2+2yev4joPCnUBrRQUi dDLN42/p2N7tB+vLaXXqTwbwRMPOYXrtNDYaKuYvFhfUG+/FFLbh6b9g/9h3bswYse9w x5JUc5FQOUYn1JcepavOwRLx6vAUDl258UGxF+NuR7dEjzHX27cVUbKp3ahrQmO3Z4Hb PyAtthZgiL3CBem81vTExltYzI8R+h/z3Ix7so1ioIAIOqQZPXwtJP+fJl2jQhowyvQO MSpMqplcWEd3kOtPrL598fc+minOfmrKKTEcBgFXEZJtbfSbvsj8qq06at43H0UIXT+n HOww== X-Gm-Message-State: APjAAAWdAfgR0W35xQizZYTUZB0xH5WkrImVkd05hUeJOOqQy8iSCCKg cx2+cZobTqO4uSI7h69RVCk9HVoNPVsldaZpuJYkjt3B X-Received: by 2002:a1c:a9cb:: with SMTP id s194mr5148663wme.92.1573159221150; Thu, 07 Nov 2019 12:40:21 -0800 (PST) MIME-Version: 1.0 References: <20191107132755.8517-1-jonas@norrbonn.se> In-Reply-To: <20191107132755.8517-1-jonas@norrbonn.se> From: =?UTF-8?B?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS14KS+4KSwKQ==?= Date: Thu, 7 Nov 2019 12:40:04 -0800 Message-ID: Subject: Re: [PATCH v3 0/6] Add namespace awareness to Netlink methods To: Jonas Bonn Cc: nicolas.dichtel@6wind.com, linux-netdev , linux-kernel@vger.kernel.org, David Miller Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 7, 2019 at 5:30 AM Jonas Bonn wrote: > > Changed in v3: > - added patch 6 for setting IPv6 address outside current namespace > - address checkpatch warnings > - address comment from Nicolas > > Changed in v2: > - address comment from Nicolas > - add accumulated ACK's > > Currently, Netlink has partial support for acting outside of the current > namespace. It appears that the intention was to extend this to all the > methods eventually, but it hasn't been done to date. > > With this series RTM_SETLINK, RTM_NEWLINK, RTM_NEWADDR, and RTM_NEWNSID > are extended to respect the selection of the namespace to work in. > This is nice, is there a plan to update userspace commands using this? > /Jonas > > Jonas Bonn (6): > rtnetlink: allow RTM_SETLINK to reference other namespaces > rtnetlink: skip namespace change if already effect > rtnetlink: allow RTM_NEWLINK to act upon interfaces in arbitrary > namespaces > net: ipv4: allow setting address on interface outside current > namespace > net: namespace: allow setting NSIDs outside current namespace > net: ipv6: allow setting address on interface outside current > namespace > > net/core/net_namespace.c | 19 ++++++++++ > net/core/rtnetlink.c | 80 ++++++++++++++++++++++++++++++++++------ > net/ipv4/devinet.c | 61 ++++++++++++++++++++++-------- > net/ipv6/addrconf.c | 13 +++++++ > 4 files changed, 145 insertions(+), 28 deletions(-) > > -- > 2.20.1 >