Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Nov 2019 12:48:09 -0800 (PST)
From:   David Rientjes <rientjes@google.com>
To:     Yunfeng Ye <yeyunfeng@huawei.com>
cc:     akpm@linux-foundation.org, jgg@ziepe.ca, mhocko@suse.com,
        jglisse@redhat.com, minchan@kernel.org, peterz@infradead.org,
        jack@suse.cz, rppt@linux.ibm.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        "hushiyuan@huawei.com" <hushiyuan@huawei.com>,
        "linfeilong@huawei.com" <linfeilong@huawei.com>
Subject: Re: [PATCH] mm/madvise: replace with page_size() in
 madvise_inject_error()
In-Reply-To: <7296c9ca-f8a7-f31b-d090-cc6bf5ee1df4@huawei.com>
Message-ID: <alpine.DEB.2.21.1911071247480.88963@chino.kir.corp.google.com>
References: <29dce60c-38d6-0220-f292-e298f0c78c4d@huawei.com> <alpine.DEB.2.21.1911061327550.155572@chino.kir.corp.google.com> <7296c9ca-f8a7-f31b-d090-cc6bf5ee1df4@huawei.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 7 Nov 2019, Yunfeng Ye wrote:

> >> The function page_size() is supported after the commit a50b854e073c
> >> ("mm: introduce page_size()").
> >>
> >> Replace with page_size() in madvise_inject_error() for readability.
> >>
> >> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> >> ---
> >>  mm/madvise.c | 8 ++++----
> >>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/mm/madvise.c b/mm/madvise.c
> >> index 2be9f3fdb05e..38c4e7fcf850 100644
> >> --- a/mm/madvise.c
> >> +++ b/mm/madvise.c
> >> @@ -856,13 +856,13 @@ static int madvise_inject_error(int behavior,
> >>  {
> >>  	struct page *page;
> >>  	struct zone *zone;
> >> -	unsigned int order;
> >> +	unsigned int size;
> > 
> > Should be unsinged long.
> > 
> ok, thanks. Andrew has already help me modify the patch and add to -mm tree.
> 

Good deal, in that case:

Acked-by: David Rientjes <rientjes@google.com>