Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1608820ybx; Thu, 7 Nov 2019 14:24:08 -0800 (PST) X-Google-Smtp-Source: APXvYqxOTehBBj5QmZ51iuOAf53BDVgCrZD3FV6/09TbnAnHNIad/yH9KrGoGR4W0Mq07haS/O+U X-Received: by 2002:a05:6402:1b90:: with SMTP id cc16mr6646321edb.304.1573165448363; Thu, 07 Nov 2019 14:24:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573165448; cv=none; d=google.com; s=arc-20160816; b=Su4iZuETo6ppzj8rhPasKadqf7Njb9mrmhwe6x9vycF4xbC/4HLPYDk08uCILl3dCT wKk0Vu/YCovvukaXlzrk1dIeXtJpjTAdO/4WLW9CfAZSWKkkSgJKX3uIbxkRbLNmUz0s k6eRV9MjVfzVzjXAzuh1sXw8XLRvj1IB1xUBZ7WEKU/A6oJSaVcX1+YnWEk6tNXJ20SZ nbmRr7mFqLsm6NLt3S8yKeONMYP1ITP6jl1rg82sJY21dIc+kIrDKm45xaFQUi/6H6p3 omCVJzn8H+6pwCONWryw58Wwxp14hltFMDNWMoFjFMsTDXHSmKHV7pkI6GMOMjFMI8gO VBmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xMNm6t2ph7wCQWghQCKNnHZrmoj/XsysP7PZ5RLtuvc=; b=fOtTP+ZChSAttnzeumTIJvbyVIQa4W7fUZ6BaDoUuUZ5pSLWFAjx+Hf9eqxEvD2qt5 TRxMbPY27J4Sy1iNIxby8bEl4MaSXFMb7efrIGghgQvcIiDeMIXnvGFgHn184249/1Ug wxnJ6RMKUN4dyI3HnYcXbLOyv0Lh1MslkTT9rxA6pn3QPIHa9hSBvhGPYxZep7ptqV9Q Ujbvemm5MIDJaAnFVctUZcFzwpAfMMScvLXWk5+BExH6w70HD+uDLan/vPRHIb4GyEjH zPLfQxaSirYDh5F0fwo6ofQWUYHl00ipa+rAPhHgeRmoroSu+m1CvaOPbOzli1maXCZD 1Deg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cgwqdvpx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x28si3150877edl.21.2019.11.07.14.23.44; Thu, 07 Nov 2019 14:24:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cgwqdvpx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727148AbfKGWVF (ORCPT + 99 others); Thu, 7 Nov 2019 17:21:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:40280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbfKGWVF (ORCPT ); Thu, 7 Nov 2019 17:21:05 -0500 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DF4A206C3; Thu, 7 Nov 2019 22:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573165264; bh=o/q0uASjJnBVaAfXrJkzJZuhoIg5oq6iWOmQ1ROAA0I=; h=From:To:Cc:Subject:Date:From; b=CgwqdvpxFsYFx12bPiJSAYNr8E+vT5BSY7bZLFBBgW79yCMnmfg8oz9CqenvyXZHT muvgLNiW2RIlaUpPF0niXHW/0E5DGj7maM5/Lta4Su2saJMIqfrq4LUvBcslhfalM0 rgcPlMplJkcgKk7ZRpqxk2Q6X2wphJGkYQl4hHhg= From: Bjorn Helgaas To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Zhou , David Airlie , Daniel Vetter Cc: Frederick Lawler , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH 0/2] drm: replace magic nuumbers Date: Thu, 7 Nov 2019 16:20:45 -0600 Message-Id: <20191107222047.125496-1-helgaas@kernel.org> X-Mailer: git-send-email 2.24.0.rc1.363.gb1bccd3e3d-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas amdgpu and radeon do a bit of mucking with the PCIe Link Control 2 register, some of it using hard-coded magic numbers. The idea here is to replace those with #defines. I haven't signed off on these because the first one actually changes the bits involved because the existing code looks like it might have a typo. But I have no way to know for sure. I don't intend the Target Link Speed patch to change anything, so it should be straightforward to review. Bjorn Helgaas (2): drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions drm: replace Target Link Speed magic numbers with PCI_EXP_LNKCTL2 definitions drivers/gpu/drm/amd/amdgpu/cik.c | 22 ++++++++++++++-------- drivers/gpu/drm/amd/amdgpu/si.c | 18 +++++++++++------- drivers/gpu/drm/radeon/cik.c | 22 ++++++++++++++-------- drivers/gpu/drm/radeon/si.c | 22 ++++++++++++++-------- include/uapi/linux/pci_regs.h | 2 ++ 5 files changed, 55 insertions(+), 31 deletions(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog