Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1673015ybx; Thu, 7 Nov 2019 15:27:38 -0800 (PST) X-Google-Smtp-Source: APXvYqyU4YatkKZy3JvGuDdv7DCgZYdigsPwmYLodIRkgaMGWJifz/Ywc3uNL4j/O1v9OcqTAunE X-Received: by 2002:a05:6402:54a:: with SMTP id i10mr6626436edx.230.1573169257815; Thu, 07 Nov 2019 15:27:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573169257; cv=none; d=google.com; s=arc-20160816; b=jyMhiDBjyD1dJrWgfGXessUHEvbNhQJSwsE/cqIFGBnwOa3PdDi7KCkkSKN9yxVF2B if+s6jfeDHiFG9b4MFDGwl/psKrUL1KHinhVGOSKFiZy/xBQPEOwdSYLiVf+0vOsY+8u jCfO8QY8hzPW10edUN/dWujX1cYCHDPcuv+blAIFCrpb0iDPxJOj9odm0mBsE5dCdJr+ RVvHDx/PC2btRM/I9Bg0WKuM+VtAepIMoR4iTIsm151ou3W8XUieOAEBIwkRvABpR/RB WGt9p7ZY2Hdv11Yh99md6JbqjShUnuEHKfZlYa1VPhqQSKD1WCgpUIsjDegMeitlb5ni 8lCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=67GJkzeTB1r9TY3zfrkhfU668YZxwSF00/Mr8MX14tI=; b=U1F/ljHtUeNSl42LLL0VmrkHZ3PhqaQ8kVkwVUnY+DiXUq2SRpvH8lhoGjb9yLWuGP tQxmg3IfkdJcCu2oKhoayf2lVz9pnjafMgKILPnGOpXajhdEu6znSns3DQApqY0fnJeh HteMQ71ti8ZgVTK9FVHwRZJBdY9dAeZmIYQ06/CIQI0obuFEPkJdRHXKrE/yaxG4dAPY L3U40gTbSYFLTDfbpt5mRb6cnFcrIdqA3dsqLTc8e/8DyX4BEHAbvPowqG+v6shNXDNO I2zVSjazjs0BAFTL9SYhqrDqjoHMq5xqDdFvZYRQfrkSeROovK0xPk8ME9vBk7BS+mT3 zFRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c25si2582945eja.24.2019.11.07.15.27.14; Thu, 07 Nov 2019 15:27:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbfKGXYg (ORCPT + 99 others); Thu, 7 Nov 2019 18:24:36 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:49826 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbfKGXYf (ORCPT ); Thu, 7 Nov 2019 18:24:35 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8B50A15371C2E; Thu, 7 Nov 2019 15:24:34 -0800 (PST) Date: Thu, 07 Nov 2019 15:24:33 -0800 (PST) Message-Id: <20191107.152433.2093440519085855964.davem@davemloft.net> To: bianpan2016@163.com Cc: johannes.berg@intel.com, swinslow@gmail.com, 92siuyang@gmail.com, allison@lohutok.net, mkubecek@suse.cz, andreyknvl@google.com, tglx@linutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] nfc: netlink: fix double device reference drop From: David Miller In-Reply-To: <1573108190-30836-1-git-send-email-bianpan2016@163.com> References: <1573108190-30836-1-git-send-email-bianpan2016@163.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Nov 2019 15:24:34 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian Date: Thu, 7 Nov 2019 14:29:50 +0800 > The function nfc_put_device(dev) is called twice to drop the reference > to dev when there is no associated local llcp. Remove one of them to fix > the bug. > > Signed-off-by: Pan Bian > --- > v2: change subject of the patch Applied, with Fixes: tags added, and queued up for -stable, thanks.