Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1741219ybx; Thu, 7 Nov 2019 16:38:36 -0800 (PST) X-Google-Smtp-Source: APXvYqw5fLhCgrC9H2k2QBoYXP+bOjWc/VRwXuVkZD4mrrmCF8WWVUeN1WqxPgAv5qvU07Vp1Rcs X-Received: by 2002:a50:b262:: with SMTP id o89mr6977384edd.170.1573173516327; Thu, 07 Nov 2019 16:38:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573173516; cv=none; d=google.com; s=arc-20160816; b=y9VQB5VBEe95frdyKOpGaFV/H3sRPZep9Bkf0Zc9ZJrD24LLKK0D5lbJSogec5b/qT bLFFNfwo+CNLoPNNFEP7NscR9++qxD71/WBwuS8SwFiRGTqT7o/Ae+hAnrQAtUzxWpD5 p1+R9Ymu+alpBYC9ygml6opqtxEcCX5P/npMPJdBN4GeVXJdBo9t8kmj1/kUxhdZTcXI NjB2AVKg5PdF/1EYupIaeF155NTHN8MNLDxmnzSWdOs4hLZhNe4OPojUrB/FqHWe2NKs VEQGT/O4jr2QJfR4qed6f2bjoFDc5jJjbopON4rfz9RNHu+TBg7NqKwSwrtG1i7l3BWd 0F4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:user-agent:organization:references:in-reply-to:date:cc :to:from:subject; bh=DAFqBQusEjASTtFk6BxPAZBxrR6Q/whNlvwmZsqt0EA=; b=zR5w21T7hJHOP42d8NmzMVe3QRMfbekAtrZScjjJ8B4CZMGXgw9GupD5B8qUOD4Ec3 TkCDLd4wfuktPIDTkn8275YZ+gYVpJpPZVXeDGs39tRqxVewb0GGKDloMfn1CckXNlfW SqUZRYmvDEzXImCI/St2Rrev1L+oPCcSn2W2yf7sN5EEsWSBhc5gQairJG+7yhb7O7wx 9+bpLa3EIMJky6WTwUr65Aqtl+/TX8aWbqG71jNPkr+HuUkd3XMO7ANogPIcvvVCxi27 XUTYWlQfbeoWr3JPeSDvFcHg37u1tcxVXpPY4xFZMY6odrQ5idG72ISo5wOgFBWmC4IY 9HzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dd5si2687618ejb.179.2019.11.07.16.38.11; Thu, 07 Nov 2019 16:38:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbfKHAha (ORCPT + 99 others); Thu, 7 Nov 2019 19:37:30 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33436 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725930AbfKHAh3 (ORCPT ); Thu, 7 Nov 2019 19:37:29 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA80YUF5034511 for ; Thu, 7 Nov 2019 19:37:28 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2w4tumnj6x-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Nov 2019 19:37:27 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Nov 2019 00:37:25 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 8 Nov 2019 00:37:17 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA80bGhr40173716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Nov 2019 00:37:16 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C106F52050; Fri, 8 Nov 2019 00:37:16 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2601B5204E; Fri, 8 Nov 2019 00:37:16 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id C87D3A01E3; Fri, 8 Nov 2019 11:37:13 +1100 (AEDT) Subject: Re: [PATCH 10/10] ocxl: Conditionally bind SCM devices to the generic OCXL driver From: "Alastair D'Silva" To: Frederic Barrat Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Keith Busch , Ira Weiny , Anton Blanchard , Krzysztof Kozlowski , Vasant Hegde , David Gibson , Hari Bathini , Allison Randal , Anju T Sudhakar , Mahesh Salgaonkar , =?ISO-8859-1?Q?C=E9dric?= Le Goater , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , Andrew Morton , David Hildenbrand , Oscar Salvador , Michal Hocko , Pavel Tatashin , Wei Yang , Qian Cai , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org Date: Fri, 08 Nov 2019 11:37:14 +1100 In-Reply-To: References: <20191025044721.16617-1-alastair@au1.ibm.com> <20191025044721.16617-11-alastair@au1.ibm.com> Organization: IBM Australia Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1 (3.34.1-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19110800-0020-0000-0000-0000038390E2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110800-0021-0000-0000-000021D9C758 Message-Id: <46d72d7b2f91900c4499db127e365baade38e18c.camel@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-07_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911080004 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-11-07 at 19:08 +0100, Frederic Barrat wrote: > > Le 25/10/2019 à 06:47, Alastair D'Silva a écrit : > > From: Alastair D'Silva > > > > This patch allows the user to bind OpenCAPI SCM devices to the > > generic OCXL > > driver. > > > > Signed-off-by: Alastair D'Silva > > --- > > I'm wondering if we should upstream this. Is it of any use outside > of > some serious debug session for a developer? > Also we would now have 2 drivers picking up the same device ID, > since > the SCM driver is always registering for that ID, irrespective of > CONFIG_OCXL_SCM_GENERIC > > Fred > I think I'll drop this patch. It's easy enough to maintain out-of-tree for our in-house SCM hardware engineers. > > > drivers/misc/ocxl/Kconfig | 7 +++++++ > > drivers/misc/ocxl/pci.c | 3 +++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/drivers/misc/ocxl/Kconfig b/drivers/misc/ocxl/Kconfig > > index 1916fa65f2f2..8a683715c97c 100644 > > --- a/drivers/misc/ocxl/Kconfig > > +++ b/drivers/misc/ocxl/Kconfig > > @@ -29,3 +29,10 @@ config OCXL > > dedicated OpenCAPI link, and don't follow the same protocol. > > > > If unsure, say N. > > + > > +config OCXL_SCM_GENERIC > > + bool "Treat OpenCAPI Storage Class Memory as a generic OpenCAPI > > device" > > + default n > > + help > > + Select this option to treat OpenCAPI Storage Class Memory > > + devices an generic OpenCAPI devices. > > diff --git a/drivers/misc/ocxl/pci.c b/drivers/misc/ocxl/pci.c > > index cb920aa88d3a..7137055c1883 100644 > > --- a/drivers/misc/ocxl/pci.c > > +++ b/drivers/misc/ocxl/pci.c > > @@ -10,6 +10,9 @@ > > */ > > static const struct pci_device_id ocxl_pci_tbl[] = { > > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x062B), }, > > +#ifdef CONFIG_OCXL_SCM_GENERIC > > + { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0625), }, > > +#endif > > { } > > }; > > MODULE_DEVICE_TABLE(pci, ocxl_pci_tbl); > > -- Alastair D'Silva Open Source Developer Linux Technology Centre, IBM Australia mob: 0423 762 819