Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Fail (protection.outlook.com: domain of arm.com does not
 designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   "Jianyong Wu (Arm Technology China)" <Jianyong.Wu@arm.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "yangbo.lu@nxp.com" <yangbo.lu@nxp.com>,
        "john.stultz@linaro.org" <john.stultz@linaro.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "maz@kernel.org" <maz@kernel.org>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Mark Rutland <Mark.Rutland@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        Suzuki Poulose <Suzuki.Poulose@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Steve Capper <Steve.Capper@arm.com>,
        "Kaly Xin (Arm Technology China)" <Kaly.Xin@arm.com>,
        "Justin He (Arm Technology China)" <Justin.He@arm.com>,
        nd <nd@arm.com>
Subject: RE: [RFC PATCH v6 4/7] time: Add mechanism to recognize clocksource
 in time_get_snapshot
Thread-Topic: [RFC PATCH v6 4/7] time: Add mechanism to recognize clocksource
 in time_get_snapshot
Thread-Index: AQHVilqW9INaaa6hrkmF99YEVswOAKd/bNoAgAEv+oA=
Date:   Fri, 8 Nov 2019 02:34:57 +0000
Message-ID: <HE1PR0801MB16767168475257E9119C3550F47B0@HE1PR0801MB1676.eurprd08.prod.outlook.com>
References: <20191024110209.21328-1-jianyong.wu@arm.com>
 <20191024110209.21328-5-jianyong.wu@arm.com>
 <alpine.DEB.2.21.1911070852551.1869@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1911070852551.1869@nanos.tec.linutronix.de>
Accept-Language: en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Jianyong.Wu@arm.com; 
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-Microsoft-Antispam-Message-Info-Original: 0sDQ5v4bsIlURXo9/J6EIcRpiTRwufiFwIdJLM+1sYVZoJpj62Hw9tbqHL1wrCRXHMxQ70NuU14MGqxwZPdk5dmlSBBCsnj5XNj3PtnldRplsYtJz3dYHS0sKlzzR3M7wSS2xIiWnxnb8KjA+bd+GrBRLGRYqZr6PcFznuci4Ikv2IThN9nHFuIU6XCLOLy7ZwADkoVvR8EtGI48z4FB3sAHFQovSTl3y+3xxbcN5HA54EMnUrCGEkyar/cnDVzE9cdKz3oFfkWryDE2cMogyzftobqCa2ZIeeK5vX8qhcA40DoRD2cnDi4pg616Qywk8Szzean0hP7UTReh0W5N+8AW0i145/5UMFcoVAOXAGW66/YEq8sl1xvt8om1sRIG6o9MnjTZbCmgyYs42/IvN0OeKUnw07JcjqTyXfYKhpEd35q0c/QM3VduEi2hteTg
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1642
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Jianyong.Wu@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(376002)(346002)(396003)(136003)(1110001)(339900001)(13464003)(199004)(189003)(23726003)(81156014)(486006)(446003)(126002)(8746002)(8936002)(476003)(336012)(33656002)(26005)(36906005)(54906003)(105606002)(7736002)(74316002)(305945005)(81166006)(356004)(53546011)(97756001)(6116002)(76176011)(3846002)(186003)(99286004)(8676002)(450100002)(11346002)(316002)(102836004)(7696005)(2906002)(9686003)(26826003)(70206006)(76130400001)(5660300002)(50466002)(55016002)(86362001)(6246003)(14444005)(14454004)(478600001)(66066001)(47776003)(6506007)(4326008)(6862004)(46406003)(229853002)(52536014)(25786009)(22756006)(70586007)(87944003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB4296;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Fail;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: af5d8f6a-ae40-4735-84c2-08d763f43f2d
NoDisclaimer: True
X-Forefront-PRVS: 0215D7173F
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: O1e+yb8PMrqxej0uPSvfbYdRd/w5HZSUVTB5AklI08yPBImLh8e050eYyFJvYrAxd88U0CCrLLB2E34OglRzsGYSnb6565QpcRDPSLR9IZ5S6KFIhiyANH/xbz7+cP0+gXVkmIZRmb2NKLyXBGRa6gRkc7wdc3nZrJ0ZTw68UlOai5ftE9GRFmzjrNnNAKoNsZTTfRLNVb5+lJopku7EQXxOaePKZdKyxSzM1OGVHUUVPemfSZ95qb5UrbqBVMLekhYAMo9/uKnLRGPtH5XsMeRdSH48gYBboneaH5mTSx93do10ZgnwOm0iYdzvV3dfiJ8p/qhUy/DutX0LMsBtW46Kkh766C//Mc85jO7c7cR5ZDPspd0i7hOZr6OTTewphKzwByJqjXtUin+rVylFYEHWveS9WP0Tjfe+Ykxx6cBUzZUCFbLaKJZuq4skiiJE
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2019 02:35:06.7677
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ba5fcc04-e399-46ae-c445-08d763f4447f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4296
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi tglx,

> -----Original Message-----
> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Thursday, November 7, 2019 3:56 PM
> To: Jianyong Wu (Arm Technology China) <Jianyong.Wu@arm.com>
> Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org;
> pbonzini@redhat.com; sean.j.christopherson@intel.com; maz@kernel.org;
> richardcochran@gmail.com; Mark Rutland <Mark.Rutland@arm.com>;
> will@kernel.org; Suzuki Poulose <Suzuki.Poulose@arm.com>; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> kvmarm@lists.cs.columbia.edu; kvm@vger.kernel.org; Steve Capper
> <Steve.Capper@arm.com>; Kaly Xin (Arm Technology China)
> <Kaly.Xin@arm.com>; Justin He (Arm Technology China)
> <Justin.He@arm.com>; nd <nd@arm.com>
> Subject: Re: [RFC PATCH v6 4/7] time: Add mechanism to recognize
> clocksource in time_get_snapshot
>=20
> On Thu, 24 Oct 2019, Jianyong Wu wrote:
> > From: Thomas Gleixner <tglx@linutronix.de>
> >
> > In some scenario like return device time to ptp_kvm guest, we need
> > identify the current clocksource outside core time code.
> >
> > This patch add a mechanism to recognize the current clocksource by
> > export clocksource id in time_get_snapshot.
>=20
> Please check Documentation/process/submitting-patches.rst and search for
> 'This patch'.
>=20

Yeah, the expression should be more impersonal.

> > diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
> > index b21db536fd52..ac8016b22734 100644
> > --- a/include/linux/clocksource.h
> > +++ b/include/linux/clocksource.h
> > @@ -19,6 +19,7 @@
> >  #include <linux/of.h>
> >  #include <asm/div64.h>
> >  #include <asm/io.h>
> > +#include <linux/clocksource_ids.h>
>=20
> Please place that include to the other linux includes. You might notice t=
hat
> there is ordering here.
>
Ok,=20
=20
> But where is that include? It's not part of that series, so how is this s=
upposed
> to compile?

OMG! Sorry, I added this file when I prepared my patches but missed to incl=
ude it into this patch! This must be avoid latter.

Thanks
Jianyong

>=20
> Thanks,
>=20
> 	tglx