Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1923921ybx; Thu, 7 Nov 2019 19:58:11 -0800 (PST) X-Google-Smtp-Source: APXvYqwIidywI3a8gvKlhhFIflkGmCdl4ZQNjHHiv0SPDUIlBd6yhvVYzHlnVgSa1Ja8sbE5E10l X-Received: by 2002:aa7:db52:: with SMTP id n18mr7570674edt.169.1573185490970; Thu, 07 Nov 2019 19:58:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573185490; cv=none; d=google.com; s=arc-20160816; b=NsNpxPgB7wmcHxcMDhnX5Fy5dFxSRq5Ye+k1yM1XczfklOms+4H8KhPtNy26L4d5JF I7B4oB/ElbmyxXpCSaXWvHHDTbkADj2FlYn0ZQ3I/AltU7i3/5AaMRKVgcLnqkrDf7K7 nEVVIXZkKQFIJ9XCXFk1sW55R0l5UsskDg3ULgFy+6tuN4499+2FItf4fUsbJV8Aitde puMFQmKMW/Khp3aCem1pO9+GuA8YnetrBWO5wysh9UsA2HfQ6h8/humcODACb6HWolTu L3ivexOIF+70nIc++51ug7rMDy27iAehje/2i9ew0ub/7yd2osqSenHd6/UxyKALsRmD K4fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tPr/MAsRIcHq2Pek4YtUUvtKGH2Qld3lD3sGMlxDfm4=; b=0xFkeXj406NmwS5P9+3UXc+ariy6F2UwoEJ0tvC0M5XLPLSxAMgQCgiuTO8wlGbgIS zrjVNxfu0zVi45WAWsEEssUvMH/taJFUjS5uhotNjGnerK6B7nnMu4DOba+doFW5ZRCS iAZ3vSjH0KFnmqdPXh4UN0p5LP5imkR0bvzNeG0X6KKDBspHUuhyPpiRPBQvK9EIBNMO dZmbmy1+uvQEvgW6fOioviO/xbg5Qv6gCAgiht73QMqAlRB51Ey9hTcNGHwhni+ozt++ h73pwjOpUJKLp9fUR1bTxkl/lg9OWXTOb3OQBde4quQbrDBg8yvEsmmAb0kNdI7anV6N HsGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=glynSCKH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n19si2832619ejk.264.2019.11.07.19.57.47; Thu, 07 Nov 2019 19:58:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=glynSCKH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729823AbfKHDyk (ORCPT + 99 others); Thu, 7 Nov 2019 22:54:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:46042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728302AbfKHDyk (ORCPT ); Thu, 7 Nov 2019 22:54:40 -0500 Received: from localhost (unknown [106.200.194.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09D58214DB; Fri, 8 Nov 2019 03:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573185279; bh=MIIXRJaBYrNEXOYhmNyw15hFAChncCB29PqU5uPxEfc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=glynSCKHMYu10EcMhBORu0ErVBKrUcV98fhZ85ehrkiuejf16AuHEIuP6/tgXO7Xm R+mpks1IK23r3mS/Lj+B9ra8S7pqE+j4peTTVcxubI5Ui8tSR8/zjslW/6iqSFoqKi 3VS1n5/WKhODgXPpJ8t1Z0vY/WwCCYnolu4VCC6c= Date: Fri, 8 Nov 2019 09:24:35 +0530 From: Vinod Koul To: Chuhong Yuan Cc: Paul Cercueil , Zubair Lutfullah Kakakhel , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove Message-ID: <20191108035435.GR952516@vkoul-mobl> References: <20191104161622.11758-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191104161622.11758-1-hslester96@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05-11-19, 00:16, Chuhong Yuan wrote: > The remove misses to disable and unprepare jzdma->clk. > Add a call to clk_disable_unprepare to fix it. Applied, thanks -- ~Vinod