Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 8 Nov 2019 08:23:42 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Oliver Neukum <oneukum@suse.com>
Cc:     Alan Stern <stern@rowland.harvard.edu>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4.19 114/149] UAS: Revert commit 3ae62a42090f ("UAS: fix
 alignment of scatter/gather segments")
Message-ID: <20191108072342.GA583220@kroah.com>
References: <Pine.LNX.4.44L0.1911051007140.1678-100000@iolanthe.rowland.org>
 <1572968467.2921.27.camel@suse.com>
 <20191105163805.GB2760793@kroah.com>
 <1573126365.3024.4.camel@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1573126365.3024.4.camel@suse.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 07, 2019 at 12:32:45PM +0100, Oliver Neukum wrote:
> Am Dienstag, den 05.11.2019, 17:38 +0100 schrieb Greg Kroah-Hartman:
> > > > Given this information, perhaps you will decide that the revert is 
> > > > worthwhile.
> > > 
> > > Damned if I do, damned if I do not.
> > > Check for usbip and special case it?
> > 
> > We should be able to do that in the host controller driver for usbip,
> > right?  What is the symptom if you use a UAS device with usbip and this
> > commit?
> 
> Yes, that patch should then also be applied. Then it will work.
> Without it, commands will fail, as transfers will end prematurely.

Ok, I'm confused now.  I just checked, and I really have no idea what
needs to be backported anymore.  3ae62a42090f ("UAS: fix alignment of
scatter/gather segments") was backported to all of the stable kernels,
and now we reverted it.

So what else needs to be done here?

thanks,

greg k-h