Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2152263ybx; Fri, 8 Nov 2019 00:23:56 -0800 (PST) X-Google-Smtp-Source: APXvYqxPAWX/xElcyFtKEZwa/bfJ0qlxsVZY661OMSP6EoSl0EaV/eC9AvAEsYbrOW+1NbJ7vKiv X-Received: by 2002:a50:9a85:: with SMTP id p5mr8681042edb.223.1573201436309; Fri, 08 Nov 2019 00:23:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573201436; cv=none; d=google.com; s=arc-20160816; b=psrPfxamKms8j3ah0vmfywgzylvhU5vwZ08N/w0/e5ihVMINKNP+0D4/mMdr5Va7R/ YjzPkSTaXw8yXQVRnkR94ICDaO8SVmD8JmptVReSW6U0rBS1Kx6SpnbOp7lJqc1srfPE DFOgAozXbNhyqnOlLos7BmXwaOpUvvuLmr4s2MmDkb3K4sj5X7Vf8yRXiOygdiy7dzeX iGFcCs8HS4CtW9m8pbQZ16QUB44FcFuBrc5JSKp2S18uyosECvBPI4aqfc42+nooFAna 2KHBgBB8RP6etchHJ0L6aSc1QRZL+100ogY6fjtlns1VIHgQr0rZ0Unr2ocSjGGv8X8b CKCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=mMdkQw9GCzNnE6id1/kmfJQMZe7Pee479Do6rdFG5MA=; b=AWyTk4XkZtbDR984BrDntH2NTVqOppm+QHDR8CG0ma7zDTwR+oGVy0Hi99DyjehC8o YGx26uDHC/pzSSwksxvkH9lKm9pO8Mo3ARi/3ciWpEKQaYYCX6XLuUY1UcqxCQb9vFDF iYGwGbhBI+VRtN8C7qteYFCIludg7l2UvVmxOsZ0e4cJajNOuLOgtBlFqQz/jkSWgKSo ybBQSgfFAxo7DTq+DpmCmWwD/1f96c3HK+g4sTFTV1kfXctCvlsxcYG7VFwbG++/eaqe ejvDVeVF7mDECOekln+34fO+4m7EnAY2ki90M3CS3Nv0u0rb2KjaUshXHzcSn8ekgiai Ij/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11si3196382eju.106.2019.11.08.00.23.32; Fri, 08 Nov 2019 00:23:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730411AbfKHIUp (ORCPT + 99 others); Fri, 8 Nov 2019 03:20:45 -0500 Received: from mga06.intel.com ([134.134.136.31]:10567 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbfKHIUo (ORCPT ); Fri, 8 Nov 2019 03:20:44 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2019 00:20:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,280,1569308400"; d="scan'208";a="213200201" Received: from rafalwi-mobl.ger.corp.intel.com (HELO localhost) ([10.252.3.149]) by fmsmga001.fm.intel.com with ESMTP; 08 Nov 2019 00:20:33 -0800 Date: Fri, 8 Nov 2019 10:20:31 +0200 From: Jarkko Sakkinen To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-sgx@vger.kernel.org, akpm@linux-foundation.org, dave.hansen@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, haitao.huang@intel.com, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, kai.svahn@intel.com, bp@alien8.de, josh@joshtriplett.org, luto@kernel.org, kai.huang@intel.com, rientjes@google.com, cedric.xing@intel.com, puiterwijk@redhat.com, linux-security-module@vger.kernel.org, Suresh Siddha Subject: Re: [PATCH v23 12/24] x86/sgx: Linux Enclave Driver Message-ID: <20191108082031.GC3370@linux.intel.com> References: <20191028210324.12475-1-jarkko.sakkinen@linux.intel.com> <20191028210324.12475-13-jarkko.sakkinen@linux.intel.com> <20191029092920.GA14494@linux.intel.com> <20191030093045.GB12481@linux.intel.com> <20191031211252.GC10507@linux.intel.com> <20191105111057.GA20879@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191105111057.GA20879@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 05, 2019 at 01:11:22PM +0200, Jarkko Sakkinen wrote: > I'll add @count to address this. This output field will contain the > number of bytes actually written instead of overwriting input > parameters, which is a bad practice in anyway. > > We don't need to actually cap to anything but API must be able to > support such scenario. Caller must be prepared to deal with the > situation where the return value is zero but @count < @length. I summarized here my reasoning on @count: https://lore.kernel.org/linux-sgx/20191108081331.GB3370@linux.intel.com/ /Jarkko