Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 8 Nov 2019 09:29:39 +0100
From:   Christian Brauner <christian.brauner@ubuntu.com>
To:     Adrian Reber <areber@redhat.com>
Cc:     Shuah Khan <shuah@kernel.org>,
        Eugene Syromiatnikov <esyr@redhat.com>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: add tests for clone3()
Message-ID: <20191108082937.ypc5t2fcr2ffmlmm@wittgenstein>
References: <20191104131846.1076814-1-areber@redhat.com>
 <20191106155914.hzolyolz2w4hcn7w@wittgenstein>
 <20191108064416.GA153851@dcbz.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191108064416.GA153851@dcbz.redhat.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 08, 2019 at 07:44:16AM +0100, Adrian Reber wrote:
> On Wed, Nov 06, 2019 at 04:59:15PM +0100, Christian Brauner wrote:
> > On Mon, Nov 04, 2019 at 02:18:46PM +0100, Adrian Reber wrote:

> Not sure myself. It was just to make sure clone3() does not something
> unexpected when given wrong and unexpected input. It is the opposite to
> setting everything to zero. Not sure how much sense it makes, but as it
> already exists I would say to just keep it.

If it serves no real purpose then please remove it. It's not clear from
thist test _why_ it it expected to fail. Is it because of invalid stack
and stack_size or invalid tls etc.

> 
> > > +		args.flags = 1;
> > > +		args.pidfd = 1;
> > > +		args.child_tid = 1;
> > > +		args.parent_tid = 1;
> > > +		args.exit_signal = 1;
> > > +		args.stack = 1;
> > > +		args.stack_size = 1;
> > > +		args.tls = 1;
> > > +		break;
> > > +	case CLONE3_ARGS_INVAL_EXIT_SIGNAL_BIG:
> [...]
> 
> Let me know if you think that the CLONE3_ARGS_ALL_1 should really be
> removed. I will fix the other two things you mentioned and resend a new
> version.

Yes, please.

	Christian