Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2167830ybx; Fri, 8 Nov 2019 00:40:52 -0800 (PST) X-Google-Smtp-Source: APXvYqyarVtT9a8u+IOL+daUfb5/77sWxI2qsiO6tQDYe9voDP6p3Nw+fphC9RL0y1Hn+K7wR2yY X-Received: by 2002:a17:906:11cd:: with SMTP id o13mr7497029eja.272.1573202452123; Fri, 08 Nov 2019 00:40:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573202452; cv=none; d=google.com; s=arc-20160816; b=rIkzvEu0+r6kOIoxlXFAzWGRRV9EmNC48BxYwll0swhP8n0N3lNftSqE8MI+fWQ4kQ SfbCc6Z9j806HeR5cmZ347bHgwlLeCSCsv0+6E1I3UPTFpLPuzhyVkyiMX2gO0LUczx4 JBpNzEHj84RIoP4mnDnBY2hUosHdC2YQMpKEeQyvV8FXy0xLadj4N8ADPIJDdscP9CjX JiSJXY3cT8ccJsC8CNjubBXqff9rzKG7j2cjDjirtVeOEACcPURf92eKwfvhfla0xQq5 A/KqTEiXntqUQDcFqGlfjzURGcrbRCQneIKGmN1XiBgcSXWbIC+6B39QXWuEZjwaTx3p 2Eww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=Y06rTA9jyJ3Mxb7FOxzfvb/JyrQ6mJjiIx0NSmTLT3w=; b=xY1AcElHwLy76Tas0Dc/sPtkCSG4U/8Pu2mrOlGbhdwI0j21BhgYaintYjkYTbFIgg GTZ0dgF6IlP9bomenRM98LaHkhDGYDRDhYqpvV3reXjEUwIPuGPc4yVDS7tNqtXjrp1q 72mwVS9/oscuN0F9im1u+8ENvm27Bw9gbjJo0Kl7HErjtNl8zk2Q9+unw/w/HwxE5N56 1rnQHycA4sPwbnsS1AE02KH5zdM6wFdzgV33T6rtEFMaMkb2ob2KvquBxqJPkWVK11uE HMOEs/Gq3sEMa9pUHD8aYcd9UXd1d+ILe2gc3gRXeMxcztXTgaJrJj5QHR9k+Tu9yNh7 wQPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t26si3642155edc.102.2019.11.08.00.40.28; Fri, 08 Nov 2019 00:40:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730823AbfKHIhJ (ORCPT + 99 others); Fri, 8 Nov 2019 03:37:09 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:38724 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfKHIhI (ORCPT ); Fri, 8 Nov 2019 03:37:08 -0500 Received: by mail-oi1-f196.google.com with SMTP id a14so4563048oid.5; Fri, 08 Nov 2019 00:37:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y06rTA9jyJ3Mxb7FOxzfvb/JyrQ6mJjiIx0NSmTLT3w=; b=AWGAXSm2c0Yspjg8qNfi6qHsKYdT1nOowipVHrrzRIY4GxtI7ot9O1Zfw5uq7Adp4D 7KfRmLixTQMMcHFngqAPbmevJXWNkAFvVp2FGkS/uTgGnJo0jmGk7tLLqX4G/YHHLvGT ibBR54MlIv1+6/lMYCcfxYHazihL/v3mSsfp9o1jEqaBSAZ3sdAgc36l/8UWMZlyN8PX bUsafmAfcbSAcF1YsJwSH+a6wkfcIbcgwEOoJ2aaB/+QRPVOCYNHmREqkROQb8cxTlum jALbQIj5xwQApIVc7L1uH0gCudKUV4DxpiZIUWmmYaOehXsJ8E3KpW5Jb30VK47HvwIm ZIbA== X-Gm-Message-State: APjAAAUSMGdMvDVklv3rjLryuFKYu1rOj0IhzB18+1Psp8NdeXGr7EtS yE2/G58kgV/i2hcCJbqH7LJI+yt+fMKEVFOHUJ0= X-Received: by 2002:aca:fc92:: with SMTP id a140mr7932910oii.153.1573202227574; Fri, 08 Nov 2019 00:37:07 -0800 (PST) MIME-Version: 1.0 References: <20191106193609.19645-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20191106193609.19645-4-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 8 Nov 2019 09:36:56 +0100 Message-ID: Subject: Re: [PATCH 3/5] PCI: rcar: Add R-Car PCIe endpoint device tree bindings To: "Lad, Prabhakar" Cc: Bjorn Helgaas , Rob Herring , Mark Rutland , Magnus Damm , Kishon Vijay Abraham I , Marek Vasut , Yoshihiro Shimoda , linux-pci , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Andrew Murray , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux ARM , Linux-Renesas , Chris Paterson , "Lad, Prabhakar" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Thu, Nov 7, 2019 at 11:46 PM Lad, Prabhakar wrote: > On Thu, Nov 7, 2019 at 8:08 PM Geert Uytterhoeven wrote: > > On Thu, Nov 7, 2019 at 10:26 AM Lad, Prabhakar > > wrote: > > > On Thu, Nov 7, 2019 at 8:44 AM Geert Uytterhoeven wrote: > > > > On Wed, Nov 6, 2019 at 8:36 PM Lad Prabhakar wrote: > > > > > From: "Lad, Prabhakar" > > > > > > > > > > This patch adds the bindings for the R-Car PCIe endpoint driver. > > > > > > > > > > Signed-off-by: Lad, Prabhakar > > > > > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.txt > > > > > +- reg: Five register ranges as listed in the reg-names property > > > > > +- reg-names: Must include the following names > > > > > + - "apb-base" > > > > > + - "memory0" > > > > > + - "memory1" > > > > > + - "memory2" > > > > > + - "memory3" > > > > > > > > What is the purpose of the last 4 regions? > > > > Can they be chosen by the driver, at runtime? > > > > > > > no the driver cannot choose them at runtime, as these are the only > > > PCIE memory(0/1/2/3) ranges > > > in the AXI address space where host memory can be mapped. > > > > Are they fixed by the PCIe hardware, i.e. could they be looked up by the > > driver based on the compatible value? > > > yes they are fixed by the PCIe hardware and could be looked up by the driver > based on the compatible value. Thanks, so we don't need to describe them in DT. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds