Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2200829ybx; Fri, 8 Nov 2019 01:16:27 -0800 (PST) X-Google-Smtp-Source: APXvYqwC/222F8r6wL6Q0qB9xi0KR/hasgyB4CaXCwlI2psn78d9XZQMNbA7TA95efDZRIKDgGvS X-Received: by 2002:a17:906:245b:: with SMTP id a27mr7762418ejb.192.1573204586980; Fri, 08 Nov 2019 01:16:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573204586; cv=none; d=google.com; s=arc-20160816; b=WwmJyeESjXlk6TB6T3BlnEXwkJTWMzDA0VPeYHf2iHUK36vvU+cLPZ1qO7d9E3e6Bi M5sH4dZ12uh2V/sMi5uZ7A/CjLbsoW8q1gqFChxKzpobIv0aQm+enFixpkflQkWRFxmD F898lJz/fXD96Ti05swOLr6M+I+kZTzb5bg5KJtD3KtRtGALa7RuuixXXSVX9+z1HXRs Mu0/ktySlOwjk8L9rLearb3MjbeT10WOft/19pZPbs5ZVKfY17wd2DDCb6EC2S0FsR5u gFxk2UXd7dvDHCel/mLb/E6zegBRY9jMA1PnzYIW8vWq//UVnvH//ONjRDZH/t+IIQGb FtIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=X4HUuPqduwJDywZ+YnoXVi+Nbnr59h8IKAZATjF1idI=; b=EmSMRlgstts2dIc6VbnuArhyepXzdXDT8WUzwMUcgOHtrw+IKeSxGQNqWUE4rsaWx7 sljSC9MhyKcYJwM35SjH+fOm9Rt8tFK8ANBSfWdp8FD++ObRmedZ6NeXeK3neHLtM9K0 r7vjIqyhE9GGPYA0SlbkryWJzWWbe2NP9U/EU/mqqxvBkIciDELGfXgL9uDeAP+4MDSP rdH0cReTuV5F7+wdp2tpb3C5h+W33va+SYH64IBfcRgh8hvNFwwasTW12iVoCzXwzZvY F6VYbaKYyYlDLv6p13VhBxCRB3nPD8OZxUwU12NQ8DWSSp5UZ5FtwMjee5df9LJERyTD BfeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x50si4019478eda.155.2019.11.08.01.16.03; Fri, 08 Nov 2019 01:16:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730713AbfKHJMM convert rfc822-to-8bit (ORCPT + 99 others); Fri, 8 Nov 2019 04:12:12 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:55766 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730645AbfKHJMM (ORCPT ); Fri, 8 Nov 2019 04:12:12 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 19124954-1500050 for multiple; Fri, 08 Nov 2019 09:12:08 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Jani Nikula , Joonas Lahtinen , Masahiro Yamada , Rodrigo Vivi , intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20191108051356.29980-1-yamada.masahiro@socionext.com> Cc: Masahiro Yamada , Daniel Vetter , David Airlie , Mika Kuoppala , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20191108051356.29980-1-yamada.masahiro@socionext.com> Message-ID: <157320432699.9461.10436519336108145423@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH 1/2] drm/i915: change to_mock() to an inline function Date: Fri, 08 Nov 2019 09:12:07 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Masahiro Yamada (2019-11-08 05:13:55) > Since this function is defined in a header file, it should be > 'static inline' instead of 'static'. > > Signed-off-by: Masahiro Yamada Reviewed-by: Chris Wilson -Chris