Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030446AbWALPSD (ORCPT ); Thu, 12 Jan 2006 10:18:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030447AbWALPSD (ORCPT ); Thu, 12 Jan 2006 10:18:03 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:18375 "EHLO e2.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1030446AbWALPSA (ORCPT ); Thu, 12 Jan 2006 10:18:00 -0500 Date: Thu, 12 Jan 2006 07:17:41 -0800 From: "Paul E. McKenney" To: Keith Owens Cc: John Hesterberg , Matt Helsley , Jes Sorensen , Shailabh Nagar , Andrew Morton , Jay Lan , LKML , elsa-devel@lists.sourceforge.net, lse-tech@lists.sourceforge.net, CKRM-Tech , Paul Jackson , Erik Jacobson , Jack Steiner Subject: Re: [Lse-tech] Re: [ckrm-tech] Re: [PATCH 00/01] Move Exit Connectors Message-ID: <20060112151741.GA25299@us.ibm.com> Reply-To: paulmck@us.ibm.com References: <20060112065115.GB23673@us.ibm.com> <19140.1137052234@kao2.melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19140.1137052234@kao2.melbourne.sgi.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 24 On Thu, Jan 12, 2006 at 06:50:34PM +1100, Keith Owens wrote: > "Paul E. McKenney" (on Wed, 11 Jan 2006 22:51:15 -0800) wrote: > >On Thu, Jan 12, 2006 at 05:19:01PM +1100, Keith Owens wrote: > >> OK, I have thought about it and ... > >> > >> notifier_call_chain_lockfree() must be called with preempt disabled. > >> > >Fair enough! A comment, perhaps? In a former life I would have also > >demanded debug code to verify that preemption/interrupts/whatever were > >actually disabled, given the very subtle nature of any resulting bugs... > > Comment - OK. Debug code is not required, the reference to > smp_processor_id() already does all the debug checks that > notifier_call_chain_lockfree() needs. CONFIG_PREEMPT_DEBUG is your > friend. Ah, debug_smp_processor_id(). Very cool!!! Thanx, Paul - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/