Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2600603ybx; Fri, 8 Nov 2019 06:42:17 -0800 (PST) X-Google-Smtp-Source: APXvYqygcx2I4drsq3pskKGfm0fw/RLgbWSsiGAKadMVEw2nPCbMdBO6bX4GIatEJ7T1aU+cGkmO X-Received: by 2002:a17:906:4d99:: with SMTP id s25mr9290028eju.187.1573224137281; Fri, 08 Nov 2019 06:42:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573224137; cv=none; d=google.com; s=arc-20160816; b=mr1kx2JJoTpgoh5J90fAB6Pb2ljvWy1r/fOLTJCURpjkxy3IJcgiH/5OR5tJY4Hf8N p3lkM8XlIMrH8mdU+HG2VIXISlWWPnYIm0Mg+Dww3f5Q6fToL7+ThrETLYGUMlGfkfy6 vA/1d0e+cG5/XS9rhRKbv/IVyUPU0UVHC5xtqgoQZgGQr0p/tK2EoB1wvZuY5B3mKqpY zznHtG4PvG9EsLdUZT9PwMT/utsz3OeNnGSaCENS5AgC4m0ONAroE2S6M64a+AVacB72 SHvyJ6bRSqrRdSI9cWJD5/6KFLPpqV7r2EE84G0RdmzklANNyaPJENEDBwkfglOA9/H3 F5/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type :content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:cc:to:subject:dkim-signature :dkim-filter; bh=FgyVFyuCJHWS+qKVf2bnwTdN8Rtc4PgvOj9/7MINFoo=; b=QbBlBD9xZk1gE4XW2wg/pHsVwBAi3pxud4CsnkH+z2pmWPQtVA+g+CK/YV3Nm0gPiz Rc1pYALomfMI35yZJRzRjgC2xtXw9sPtaFGZ8bG/BAxUy/JNgit61BUb2vWJuNG4CPPh gtQhnkzv0VdZwRP5PRGRMTQY+v0YXx0Mp1wD6z2aAqLebcbxglXyLYZ1CrZFeKmxE1Km fCDvybGjdC/PVQPTb0j4YMikOdFrwwekJ93iwHN9ss0xzltDeUHF3h8EPT9XT9TXrw8v Kz/tcLl39DBvzzpMmKNkM6s6XxVQ+HzsInVVW9tT7NqE/5Orr0iXsEWVf+5BAYl/MljR ri9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=isAkNQJu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s35si4284850edd.261.2019.11.08.06.41.53; Fri, 08 Nov 2019 06:42:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=isAkNQJu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727256AbfKHOko (ORCPT + 99 others); Fri, 8 Nov 2019 09:40:44 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:43742 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbfKHOkn (ORCPT ); Fri, 8 Nov 2019 09:40:43 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20191108144042euoutp022e208ba6f97a3d678e57659719b2ac09~VNu5eThoh1399413994euoutp02O for ; Fri, 8 Nov 2019 14:40:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20191108144042euoutp022e208ba6f97a3d678e57659719b2ac09~VNu5eThoh1399413994euoutp02O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1573224042; bh=FgyVFyuCJHWS+qKVf2bnwTdN8Rtc4PgvOj9/7MINFoo=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=isAkNQJugGMm/PP/gcNnzlZGm2sIqBg/pXvVDSYMLN9+B+Pr0T50HNNhqlEIgdA77 D23JGzpthdwvaNGI8KZf9Gy1SN3X/LVrQ+WP9E5oQMO/9E5YbYNBjldsk+gAfK/9p/ 97qpn5y4VG5KPguGAUuOMcPg2FZld6Vj6u4cC2F0= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20191108144042eucas1p11915113d458b62a08bafa3c8c7423875~VNu5RiSp52585925859eucas1p1r; Fri, 8 Nov 2019 14:40:42 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id D1.5C.04469.96E75CD5; Fri, 8 Nov 2019 14:40:41 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20191108144041eucas1p184de963ca635a6d6325903bf960b1652~VNu4_mk802593625936eucas1p1m; Fri, 8 Nov 2019 14:40:41 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20191108144041eusmtrp1cd3a7901aa05aeda9a3daa9efdac2cfe~VNu4971TZ1442914429eusmtrp1b; Fri, 8 Nov 2019 14:40:41 +0000 (GMT) X-AuditID: cbfec7f2-569ff70000001175-5a-5dc57e6964c7 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 55.B9.04117.96E75CD5; Fri, 8 Nov 2019 14:40:41 +0000 (GMT) Received: from [106.120.51.71] (unknown [106.120.51.71]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20191108144041eusmtip245f93ed2e2edcb2559c51f012b5153e2~VNu4lB6L71069710697eusmtip2D; Fri, 8 Nov 2019 14:40:41 +0000 (GMT) Subject: Re: [PATCH 14/46] ARM: pxa: use pdev resource for palmld mmio To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Jens Axboe , linux-ide@vger.kernel.org From: Bartlomiej Zolnierkiewicz Message-ID: <490c888b-a034-c883-2f6e-d8a08753ef4d@samsung.com> Date: Fri, 8 Nov 2019 15:40:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191018154201.1276638-14-arnd@arndb.de> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHe3ZfdjecXKfpSc1opJGRLxR20ZISq0ufjKCssJx5mUM3ZXOW BiUqaiJamqRDKCJdGup8n9qH1HxjZC+alCjMl0KkmenKLLWcV8lvv/M///Oc/4GHwqSdhDul VCdzGrU8QUaK8Zbe5cFDyts9UQFWC8OsFvUKmefjhSSTsTqLM29rjzIPVgwCpmFqhGB6TZMC Zqi9nGT0X51PiNg/v4sQW1i7SLBt+nEhO/Rax46NvCDZxqd32MUGL7a1w4BHUJfFx2K5BGUK p/EPjRbHZVrNRFKz1825XwtYOirZlYdEFNBHwNi0SuQhMSWlnyGob/i+WdgQmO9WkXyxiKBg fgDfGunqNuB8w4DA2Lck4AsrgsyeGqHd5UyfhjF9NmFnF3ovlMx8weyM0ZUCKMyKsTNJB8P9 nGpkZwkdCqW2pQ0PTu+Dir/TpJ130pGwYOkmeI8TDJRNb6QQ0UGQVWMW8m+6wej0IwHPe6DV Wo7ZAwE9IoTR0s+bscOhonQC49kZZvuahDx7grk4H+cHahGs5s5sTrciMBSvkbwrBLr73q3H oNZXHIC6dn9ePgnWMZPALgPtCB+tTnwIRyhqeYjxsgRys6W82weMlUZya21eWxV2D8n0207T bztHv+0c/f+9jxFejdw4nVal4LSBau6Gn1au0urUCr/riaoGtP6xzGt9Cyb0431MF6IpJHOQ RHq+ipIS8hRtqqoLAYXJXCSirHVJEitPTeM0idc0ugRO24U8KFzmJrm1w3JFSivkyVw8xyVx mq2ugBK5p6P4oDNj3uUO1DeTasXS3QnSotqzTSnVveTBeczY4u0TXr92PMQ0obyq+en7SXxh rkwSHO7wZtDjSfnkxYKE/dGHk6tybP75daxrhVv/uYwPtpzGZQXhE6dUTK9MNYfRutQ02hYh w9mJaHVAfyM5vFz38lLYqfMdnWddrbstwzJcGycP9MU0Wvk/szZfdFQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t/xe7qZdUdjDa5N07T4O+kYu8Xqu/1s Fk1/X7FYXFhnbjHlz3Imi02Pr7FaHNvxiMni8q45bBaz3gg7cHr8/jWJ0aN/3WdWj52z7rJ7 XD5b6nHn2h42j81L6j0+b5Lz2L57OUsAR5SeTVF+aUmqQkZ+cYmtUrShhZGeoaWFnpGJpZ6h sXmslZGpkr6dTUpqTmZZapG+XYJeRvPb06wFW+Uq3v34xNzAOFWyi5GTQ0LAROLQ4eUsXYxc HEICSxklzq7awtjFyAGUkJE4vr4MokZY4s+1LjaImteMEgfmnmMGSQgLuEncmdXGCmKLCChK TH3xjBmkiFlgGZPE/7tLGUESQgJbGCW+rFQFsdkErCQmtq8Ci/MK2EnM+PIdbBCLgIrE0v9P 2EBsUYEIicM7ZkHVCEqcnPmEBcTmFDCTaFl7mh3EZhZQl/gz7xIzhC0ucevJfCYIW15i+9s5 zBMYhWYhaZ+FpGUWkpZZSFoWMLKsYhRJLS3OTc8tNtIrTswtLs1L10vOz93ECIzPbcd+btnB 2PUu+BCjAAejEg/vi+qjsUKsiWXFlbmHGCU4mJVEeDlbjsQK8aYkVlalFuXHF5XmpBYfYjQF em4is5Rocj4wdeSVxBuaGppbWBqaG5sbm1koifN2CByMERJITyxJzU5NLUgtgulj4uCUamBs y7v+aWX1z8QbXMWnLxVpsIiqNDopn/a4pWVin2gm5c/Y0RIVUZ51UVb85+S+gHsmmafLbKVu xZ8v6/0eKtkbWy5e5tkhKSnYsHjWfLktvg5VTvZ3P/9uLmhzMDLrbDvBrVlV8VqKK6KD4+Ci VXsyT51TTU3Yv+7FbV2lnPZmzxW8IZ5mSizFGYmGWsxFxYkAa5A+X+UCAAA= X-CMS-MailID: 20191108144041eucas1p184de963ca635a6d6325903bf960b1652 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20191018154230epcas4p3a961777ba34c3eaa7d416665f934185d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20191018154230epcas4p3a961777ba34c3eaa7d416665f934185d References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-14-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/19 5:41 PM, Arnd Bergmann wrote: > The palmld header is almost unused in drivers, the only > remaining thing now is the PATA device address, which should > really be passed as a resource. > > Cc: Bartlomiej Zolnierkiewicz > Cc: Jens Axboe > Cc: linux-ide@vger.kernel.org > Signed-off-by: Arnd Bergmann Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > arch/arm/mach-pxa/palmld-pcmcia.c | 3 ++- > arch/arm/mach-pxa/palmld.c | 12 +++++++++--- > arch/arm/mach-pxa/{include/mach => }/palmld.h | 2 +- > drivers/ata/pata_palmld.c | 3 +-- > 4 files changed, 13 insertions(+), 7 deletions(-) > rename arch/arm/mach-pxa/{include/mach => }/palmld.h (98%) > > diff --git a/arch/arm/mach-pxa/palmld-pcmcia.c b/arch/arm/mach-pxa/palmld-pcmcia.c > index 07e0f7438db1..720294a50864 100644 > --- a/arch/arm/mach-pxa/palmld-pcmcia.c > +++ b/arch/arm/mach-pxa/palmld-pcmcia.c > @@ -13,9 +13,10 @@ > #include > > #include > -#include > #include > > +#include "palmld.h" > + > static struct gpio palmld_pcmcia_gpios[] = { > { GPIO_NR_PALMLD_PCMCIA_POWER, GPIOF_INIT_LOW, "PCMCIA Power" }, > { GPIO_NR_PALMLD_PCMCIA_RESET, GPIOF_INIT_HIGH,"PCMCIA Reset" }, > diff --git a/arch/arm/mach-pxa/palmld.c b/arch/arm/mach-pxa/palmld.c > index d85146957004..d821606ce0b5 100644 > --- a/arch/arm/mach-pxa/palmld.c > +++ b/arch/arm/mach-pxa/palmld.c > @@ -29,8 +29,8 @@ > #include > > #include "pxa27x.h" > +#include "palmld.h" > #include > -#include > #include > #include > #include > @@ -279,9 +279,15 @@ static inline void palmld_leds_init(void) {} > * HDD > ******************************************************************************/ > #if defined(CONFIG_PATA_PALMLD) || defined(CONFIG_PATA_PALMLD_MODULE) > +static struct resource palmld_ide_resources[] = { > + DEFINE_RES_MEM(PALMLD_IDE_PHYS, 0x1000), > +}; > + > static struct platform_device palmld_ide_device = { > - .name = "pata_palmld", > - .id = -1, > + .name = "pata_palmld", > + .id = -1, > + .resource = palmld_ide_resources, > + .num_resources = ARRAY_SIZE(palmld_ide_resources), > }; > > static struct gpiod_lookup_table palmld_ide_gpio_table = { > diff --git a/arch/arm/mach-pxa/include/mach/palmld.h b/arch/arm/mach-pxa/palmld.h > similarity index 98% > rename from arch/arm/mach-pxa/include/mach/palmld.h > rename to arch/arm/mach-pxa/palmld.h > index 99a6d8b3a1e3..ee3bc15b71a2 100644 > --- a/arch/arm/mach-pxa/include/mach/palmld.h > +++ b/arch/arm/mach-pxa/palmld.h > @@ -9,7 +9,7 @@ > #ifndef _INCLUDE_PALMLD_H_ > #define _INCLUDE_PALMLD_H_ > > -#include "irqs.h" /* PXA_GPIO_TO_IRQ */ > +#include /* PXA_GPIO_TO_IRQ */ > > /** HERE ARE GPIOs **/ > > diff --git a/drivers/ata/pata_palmld.c b/drivers/ata/pata_palmld.c > index 2448441571ed..400e65190904 100644 > --- a/drivers/ata/pata_palmld.c > +++ b/drivers/ata/pata_palmld.c > @@ -25,7 +25,6 @@ > #include > > #include > -#include > > #define DRV_NAME "pata_palmld" > > @@ -63,7 +62,7 @@ static int palmld_pata_probe(struct platform_device *pdev) > return -ENOMEM; > > /* remap drive's physical memory address */ > - mem = devm_ioremap(dev, PALMLD_IDE_PHYS, 0x1000); > + mem = devm_platform_ioremap_resource(pdev, 0); > if (!mem) > return -ENOMEM; >