Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2726681ybx; Fri, 8 Nov 2019 08:29:06 -0800 (PST) X-Google-Smtp-Source: APXvYqwjCsi/hXG4zzw/GhNIYcs0O8yTQ+GWDRnJ5kWw95QJrtm2ZCuLtLbJA/1XRT3uF92hLXZM X-Received: by 2002:a17:906:1fd5:: with SMTP id e21mr9284821ejt.320.1573230546695; Fri, 08 Nov 2019 08:29:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573230546; cv=none; d=google.com; s=arc-20160816; b=fRw+wJ7BqIq2H3li6353vfong2BJEYFRV4VYuNH3Ju8JHUE6hgghrKeo4Opg0ykedw IeNdW9X3K75ycz5o1BzdefWFsFuKMVYTiTxhJSvyNeSDFcybYd0uyXQVuxlcrtqk5Q0U 9a7DbEPgNSpbSp1JVuLYd8V5O8ciKQohX6gjSb836y/Cfn7YCXQpOp/qSzgDNqOYECmx cLl/wv1ZQk1inwxAZEXbiAbRnWAHWDsw3ktr6T6UhcEaPNdl4tAO1+gB+wVETYhkdlJY tvpHb9CmDy3svtq7Dbg1iPnQLpsSFpiD8h01OffMnEIMRGyd+4nkrWriEpb+gAwhkb9k FRQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=RiIe/nW+9AsCJyMreIOc9BvirXBLZtzkTWUj49kdOWI=; b=z6YeanZxVX6orOJfUqEJ9yQ88ZuRjNIDQFx+7ppAhlRRHUTvbJ1nM8xtnGWu62lg3X gJPDW6QhmhIiKfhRBKWKG6MsXijRoN4/wx89hVC4sxMrKbj7lDS5GJr810rQErLaEsoJ PNbqkx7htzeGmwRpbU3Tgj8/yxSDrS3K8Ap655K51kM4Q4HrEcTAhkrzhpAm6yUPAs1C g16trrAzJLgJnOjnB6JrxqebQd5wAbFiZVkeOiiW263YPoYy2xUNnfd1Ekd+TzEqKx6h ETBekd+P1dKu3+jbS35kwsdUz3wep93StEspbJJZTxZrw1+Rc3hb9eT7SmIMyvKB6NMH GPAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=yiW23nuA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a40si4715763edc.92.2019.11.08.08.28.41; Fri, 08 Nov 2019 08:29:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=yiW23nuA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727296AbfKHQ1v (ORCPT + 99 others); Fri, 8 Nov 2019 11:27:51 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:39618 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727210AbfKHQ1v (ORCPT ); Fri, 8 Nov 2019 11:27:51 -0500 Received: by mail-io1-f66.google.com with SMTP id k1so6995480ioj.6 for ; Fri, 08 Nov 2019 08:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RiIe/nW+9AsCJyMreIOc9BvirXBLZtzkTWUj49kdOWI=; b=yiW23nuA8TdhuuIrPqsnDodwAfZlz7kLEuj1pDzBF778A3B5Pri8hlJ+VYcC16b6z7 0hfXRCpRdcfNrWPLjHrAaxZ2qEDn8qMMaIvQ/5fOfR48fHI2qUnwlD0zX1ctDcmo30Kg bFz8oQrg3pL89wBAb0enYPVHRJ/klENw/8POBBLGoFPn2sv8ZPfTTlwg685l8ZGN2XLt WaHIJJmzPx/q5QKVcZSFYQd0fRgY03/ZuEZ6c+/Ev3Ks7ELhbvgbFeNrMjrlmBN7AEKu NIz3ipy6kdnoXPn3akIMnGDjNXhlht2ZIIEK7C34P/dKZafL+iwwLw5OaL0En/vaR7Xw xqng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RiIe/nW+9AsCJyMreIOc9BvirXBLZtzkTWUj49kdOWI=; b=r4zsri7gukyh3c/OVl1uVpW9HzPoBv8/lS5ZNnEfbVIF/EgguN0uuwRoHnkS48eW3N EwE5LdFmyLbVUqJwchd/xgYX+FEPpdEU/WFfNXEFvW2aLnvl/tJY4cE5eek/t1xfNmMG nxljHl4YJSoKlr4R9kgsfA/P7tTq8h8OZF6YkJMlQxskL1aW5e7PA/8hyYf6rjvxfyhf Ui1p9prNcLbjRTzDeABJLM4DyGR2nub5v6k4u2Hu1ngkhVkLenjGT4JQvXG8oCM95Qw3 nWSXjIxSTHf25OKpBk83pPo5Vhh6q8IwDpnAi2fF3Ewx4XhFxUROQe6kZrMeGyj9bRLJ E3gA== X-Gm-Message-State: APjAAAU2UqPSCLjgCwkMjAwsy7R3P3rwPD+IhGpGhU+fVDT62C38ooSP mfaGmdUSRdaIpYBZNf0y8q3Sow== X-Received: by 2002:a02:9f12:: with SMTP id z18mr12194050jal.10.1573230468826; Fri, 08 Nov 2019 08:27:48 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id u21sm827186ila.41.2019.11.08.08.27.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Nov 2019 08:27:47 -0800 (PST) Subject: Re: [PATCH] block: drbd: remove a stay unlock in __drbd_send_protocol() To: Bart Van Assche , Dan Carpenter , Philipp Reisner Cc: Lars Ellenberg , drbd-dev@tron.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20191107074847.GA11695@mwanda> <3a2d491f-3d24-3673-07f3-f601d5fafc97@acm.org> From: Jens Axboe Message-ID: <26822f67-1cd7-eeda-2caa-2bc7d420f173@kernel.dk> Date: Fri, 8 Nov 2019 09:27:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <3a2d491f-3d24-3673-07f3-f601d5fafc97@acm.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/19 9:26 AM, Bart Van Assche wrote: > On 11/6/19 11:48 PM, Dan Carpenter wrote: >> There are two callers of this function and they both unlock the mutex so >> this ends up being a double unlock. > > Is there a typo in the patch subject (stay -> stray)? I fixed that up while applying, fwiw. -- Jens Axboe