Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2727362ybx; Fri, 8 Nov 2019 08:29:40 -0800 (PST) X-Google-Smtp-Source: APXvYqziRufBaxu+Zd61J+D7yNO1Nue20YBECDKkrVrT8nhD5DcRF+Y+TpURihpF9VVpZp+8wMyK X-Received: by 2002:a17:906:5807:: with SMTP id m7mr9654333ejq.58.1573230580572; Fri, 08 Nov 2019 08:29:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573230580; cv=none; d=google.com; s=arc-20160816; b=L2rdHrJVgnvyve/Woz+6f+5lO7qIRI0WKmTKbgOPGpUWBGadJQ+csh0x77wYMarh94 CEbkP9GAYTA5B0ZILRkyBSGq+VbRu8A+WCVCKx/0UDsC1c1c4aQc4RWcF7qBgo+4aWv/ Nfm//fHfk8rliOWP32466mG5322fTpYKiC1rTNx2n8z40Wf7HwG+4N5vwI/Jmy4FjDh5 kv87o1CdLwEIN0L+ZolUZOchUhGU48dBHMhXZNzsORgt8w4Vf5/TMN42C4YAqaSm4Q6V VWcEceanL39fjdOk3xkRFOo81lp6iUQe8S34Q7Kmcp9Tp7oHeKfhBQnBPh2TM6Ogk4G7 EejQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=AMGqQPW5u5MrdIldnP75x+wA0d9NwehFp+ze/wZzvWE=; b=Cvg5D/4Z5R3GYhIfs7jDzgLbJ/11fp3oK5wteexG2l5WgGGW4GbFZI0Gjgnv4EJEhZ kPHDv4+ZBo/NXiH3l+A119fiIEs6TxQRwIDQlJecVUU6A+PHB7zg5IM+y9XFBafktUfr tGNkzxcul/64LNyXYT3FtNNKrbQe4W4XP9Tyt5iB8OTMQGKx4g68BcFe4JJhbv7ftR8Z yNmuBm4EPnhbdWoz5kFR96q4uDCUChwFO8gtZ0XiNvbYCLcfmtU6ZqPkFQQZTnDbAh/Y t/rxsdxz0n0YW6YxOaBR2ofe5xU/pY8LYCVCD7BpXFZ5WuMhy58nYj3/3j9pkOLGa679 xvfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p29si5097512eda.104.2019.11.08.08.29.17; Fri, 08 Nov 2019 08:29:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbfKHQ0n (ORCPT + 99 others); Fri, 8 Nov 2019 11:26:43 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38816 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbfKHQ0m (ORCPT ); Fri, 8 Nov 2019 11:26:42 -0500 Received: by mail-pg1-f193.google.com with SMTP id 15so4277904pgh.5; Fri, 08 Nov 2019 08:26:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AMGqQPW5u5MrdIldnP75x+wA0d9NwehFp+ze/wZzvWE=; b=MZIy55JuZUMqOJXENjfpPT6uUN8gBe+T8wBYH9CEx/KuPu38QK9xzb/r3PyaQG/o9B 8XaZNfKyJDhR79x7QxptmzbOnl4A0kIr3ohFDjNk4jKPvQQpQI4M2vnbcTi1zuGcdswj 8lAutcDyOEyrhrMqRQbvaKetyTcGuPZkF4aect/xIFJfXKiO2KSM95qnu1DphxKW1dGv QGkKWAMxuA9qJo7f5Cgjym5VLSK8qvtjxXKa4jhtnN4f8ZFPeVhJC0o/GCs2pqNQDxso YjhiNPpXr9gVXI1XOMLxNSih3VdeuRMucXB+T4TosFjHrs7qDCOoHSCgkuV5U6/OXqDF WIyA== X-Gm-Message-State: APjAAAU0Ru5AeMd7VzDpwXP5OflQih7MnyfYIMpdCDMt5xEkbuSMxdBB r3JDRbdfWRh0m8NgvN9/asMGPZDnBPo= X-Received: by 2002:a17:90a:9741:: with SMTP id i1mr14891484pjw.41.1573230401560; Fri, 08 Nov 2019 08:26:41 -0800 (PST) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:202:4308:52a3:24b6:2c60]) by smtp.gmail.com with ESMTPSA id p5sm5665161pgb.14.2019.11.08.08.26.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2019 08:26:40 -0800 (PST) Subject: Re: [PATCH] block: drbd: remove a stay unlock in __drbd_send_protocol() To: Dan Carpenter , Philipp Reisner Cc: Lars Ellenberg , Jens Axboe , drbd-dev@tron.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20191107074847.GA11695@mwanda> From: Bart Van Assche Message-ID: <3a2d491f-3d24-3673-07f3-f601d5fafc97@acm.org> Date: Fri, 8 Nov 2019 08:26:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191107074847.GA11695@mwanda> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/19 11:48 PM, Dan Carpenter wrote: > There are two callers of this function and they both unlock the mutex so > this ends up being a double unlock. Is there a typo in the patch subject (stay -> stray)? Thanks, Bart.