Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <c77e82629f04f0183853884abbeddd871d8f5ab7.camel@oracle.com>
Subject: Re: [PATCH] mm: provide interface for retrieving kmem_cache name
From:   Knut Omang <knut.omang@oracle.com>
To:     Christopher Lameter <cl@linux.com>,
        Michal Hocko <mhocko@kernel.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>
Date:   Fri, 08 Nov 2019 17:44:10 +0100
In-Reply-To: <alpine.DEB.2.21.1911081534470.32431@www.lameter.com>
References: <20191107115404.3030723-1-knut.omang@oracle.com>
         <20191107115806.GP8314@dhcp22.suse.cz>
         <27006f47b0b85fb99acee2a638207268aef8d010.camel@oracle.com>
         <20191107131342.GT8314@dhcp22.suse.cz>
         <alpine.DEB.2.21.1911081534470.32431@www.lameter.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-11-08 at 15:37 +0000, Christopher Lameter wrote:
> On Thu, 7 Nov 2019, Michal Hocko wrote:
> 
> > On Thu 07-11-19 13:26:09, Knut Omang wrote:
> > > On Thu, 2019-11-07 at 12:58 +0100, Michal Hocko wrote:
> > > > On Thu 07-11-19 12:54:04, Knut Omang wrote:
> > > > > With the restructuring done in commit 9adeaa226988
> > > > > ("mm, slab: move memcg_cache_params structure to mm/slab.h")
> > > > >
> > > > > it is no longer possible for code external to mm to access
> 
> That patch only affected the memcg_cache_params structure and not
> kmem_cache.
> 
> And I do not see any references to the memcg_cache_param?

Good point, I should have made explicit reference to it. 

It gets inlined into kmem_cache with CONFIG_SLUB if CONFIG_MEMCG is set
(include/linux/slub_def.h, line 112)

> The fields that all allocators need to expose are listed in
> the struct kmme_cache definition in linux/mm/slab.h.

So I take that kmem_cache::name was still intended to be public, 
just that that broke due to the inlining of struct memcg_cache_param 
in slub_def.h?

Knut