Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2832801ybx; Fri, 8 Nov 2019 09:58:08 -0800 (PST) X-Google-Smtp-Source: APXvYqxf9so3Q2jM+qaXfMymTK5kJ1RmdhZDtWU8R3HKllW0Lc1TikXwavgnZmQeC/WIqZRPu2Ph X-Received: by 2002:a17:906:6c95:: with SMTP id s21mr10259167ejr.205.1573235887964; Fri, 08 Nov 2019 09:58:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573235887; cv=none; d=google.com; s=arc-20160816; b=dekpqjJoyIGkzdDTHqjX6YZtSZeQnyT9dWi3pR4Lq80quygD+ZI/VauT0rVgzYPrzW y/8ddgNDmPo3HvL4UtLqFvl0QDF40T5wCjaGXbCUME8IATEWJJHZ7PEZpvvYvKIPRtMa zlyxB6WACKUj8z7lCAaE1tH1n8xx8vU98h6A0QyBeC0YiGYFne34k0xBpptDrVsSieWX V28jEBc3GnOtIa5UgRltmmD2b54qHeMgRHaCg67K/BKtHuqXliTM3kBw19W9wT4Lz4IS xyTh9/72g4qMdeY3tiar76qbRz8FT1E0tVQjRoN/oS4qYVGfXrIYtSwgWj81up8inKkN I13g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:to:from:date:ironport-sdr :dkim-signature; bh=36GNcpaVmpEl7Zhp6qJo1oa/lbOerM7FI0aDbeUR15E=; b=jj3Swkgz37VjeX/yYeEYvtxWGk0vLD0A5L70ErZpNRmxYl6nhvhuevgaw1h3ftcdAE cIUcOMcZBJoXQGDRZ7QUd9GAb8DAvmClFpMgrNlCEw6pHNLkWjfE+8ftQjUlR9njmTZi iWGhEfrFWaUfxJQdxHD5vpCKuHmOb89cWsc7PyejVxLev/jIRI2BNYiBlg8VZTm4JL3c 7TawKBhtTImjxfxN2uS5bSYLc8zdxMCrCry0fb9GKKMKfkKwryYYl1DQ56B4lVp1oWbB 8QhEOsY7vFh1gwTgeVVFL47dJIG4Bbh2xBxcrOCqiSbm79IMNAoheDS5NCWPg4++HRVe N/qA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b="tY/EFOi1"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w56si4784859eda.376.2019.11.08.09.57.44; Fri, 08 Nov 2019 09:58:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b="tY/EFOi1"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727233AbfKHR4j (ORCPT + 99 others); Fri, 8 Nov 2019 12:56:39 -0500 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:16623 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfKHR4i (ORCPT ); Fri, 8 Nov 2019 12:56:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1573235798; x=1604771798; h=date:from:to:subject:message-id:references:mime-version: content-transfer-encoding:in-reply-to; bh=36GNcpaVmpEl7Zhp6qJo1oa/lbOerM7FI0aDbeUR15E=; b=tY/EFOi1erhb0atSSV0Kttb00ti14eJ3jQNYMKn19u5L2SsB4L0YrqWi NZ0f7R3rbgdUwXmp+Xm3v1Kh19URnpElANqqwCT4oQu2Si/f9mUY5rweC W6cjaGj8sxic4ZUw9nIEqp6oNR3RVIiV6dOkBiqdG52RcX0n8w7evpqKE s=; IronPort-SDR: FT+JWvEkbjal9LJRHGxPqO7kowufkmmmPtG1NiKDbLQo+7iFdHreVaja1aMWmHpGO2tIetqoAk nbiIf0mNDXEg== X-IronPort-AV: E=Sophos;i="5.68,282,1569283200"; d="scan'208";a="5653874" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1e-97fdccfd.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 08 Nov 2019 17:56:35 +0000 Received: from EX13MTAUWA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1e-97fdccfd.us-east-1.amazon.com (Postfix) with ESMTPS id BB709A29FE; Fri, 8 Nov 2019 17:56:31 +0000 (UTC) Received: from EX13d09UWA002.ant.amazon.com (10.43.160.186) by EX13MTAUWA001.ant.amazon.com (10.43.160.58) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 8 Nov 2019 17:56:31 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13d09UWA002.ant.amazon.com (10.43.160.186) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 8 Nov 2019 17:56:30 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Fri, 8 Nov 2019 17:56:30 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id BB79840EDF; Fri, 8 Nov 2019 17:56:30 +0000 (UTC) Date: Fri, 8 Nov 2019 17:56:30 +0000 From: Anchal Agarwal To: "Schmauss, Erik" , , , , , , Subject: Re: [PATCH] ACPICA: Enable sleep button on ACPI legacy wake Message-ID: <20191108175630.GA3970@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <20191101212319.1FFC440EB1@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gentle ping on this one. -- Anchal On Mon, Nov 04, 2019 at 09:58:16AM -0800, Agarwal, Anchal wrote: > Apologies for resending it. Looks like it does not show in cc list it went to all mailing list however the thread do appear on lkml. > Thanks, > Anchal >  > + Rafael, Bob > > Also, is there a reason why this wasn't CC-ed to linux-acpi mailing list? It would be good to get feedback from there too.. > I think I did to all the email id's generated from get_maintainer.pl. Ccing again > + linux-acpi > > Thanks, > Erik > > > -----Original Message----- > > From: Anchal Agarwal > > Sent: Monday, October 29, 2018 10:52 AM > > Subject: [PATCH] ACPICA: Enable sleep button on ACPI legacy wake > > > > Currently we do not see sleep_enable bit set after guest resumes from > > hibernation. Hibernation is triggered in guest on receiving a sleep trigger > > from the hypervisor(S4 state). We see that power button is enabled on wake > > up from S4 state however sleep button isn't. This causes subsequent > > invocation of sleep state to fail in the guest. Any environment going through > > acpi_hw_legacy_wake() won't have sleep button enabled. > > > > Signed-off-by: Anchal Agarwal > > Reviewed-by: Balbir Singh > > Reviewed-by: Frank van der Linden > > --- > > drivers/acpi/acpica/hwsleep.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/acpi/acpica/hwsleep.c b/drivers/acpi/acpica/hwsleep.c > > index b62db8ec446f..a176c7802760 100644 > > --- a/drivers/acpi/acpica/hwsleep.c > > +++ b/drivers/acpi/acpica/hwsleep.c > > @@ -300,6 +300,17 @@ acpi_status acpi_hw_legacy_wake(u8 sleep_state) > > [ACPI_EVENT_POWER_BUTTON]. > > status_register_id, ACPI_CLEAR_STATUS); > > > > + /* Enable sleep button */ > > + (void) > > + acpi_write_bit_register(acpi_gbl_fixed_event_info > > + [ACPI_EVENT_SLEEP_BUTTON]. > > + enable_register_id, > > ACPI_ENABLE_EVENT); > > + > > + (void) > > + acpi_write_bit_register(acpi_gbl_fixed_event_info > > + [ACPI_EVENT_SLEEP_BUTTON]. > > + status_register_id, ACPI_CLEAR_STATUS); > > + > > acpi_hw_execute_sleep_method(METHOD_PATHNAME__SST, > > ACPI_SST_WORKING); > > return_ACPI_STATUS(status); > > } > > -- > > 2.15.3.AMZN > > > > >