Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2914265ybx; Fri, 8 Nov 2019 11:12:09 -0800 (PST) X-Google-Smtp-Source: APXvYqw/7BgP5NOn4JBWvODtKvfusDaxj7HNuFPlVHdZEuror/p9Le2zxj5mvBuls1R8zPm6f9c3 X-Received: by 2002:a05:6402:2049:: with SMTP id bc9mr12497276edb.56.1573240329673; Fri, 08 Nov 2019 11:12:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573240329; cv=none; d=google.com; s=arc-20160816; b=UL5i0aiGOJgcGnjFGj8jRc9W56NHqEwbqX8QIS4NGR5kTMwoviroeK/h/uwaNr8NEP UcRh/EV59iPxlP1K7D7rBAv26rvbSS5gSwZXGOdzE5oRFcAlbR5HiL9lAxonSE1rhGI5 Zo4QxRf5q83vvKv/X1JdORyESVO4p8NtzCRdFCNSVhV63mhBJBIcPPpXcenB3denC9rh BHNa0MKsSrOZq0k/czuPQWnaaaYtmzBJoD74+vgpAauHJNhOG17OgTq5L7c1U1p5UuK6 FTaG1ECr3/Z891KW788CNYBjrTmVG+lxFhNZ2/wil3ddZv0vKZK+x2hGOrh9JqOKh0ol weHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OzdzPc6Thm2VHJV1ZpR0TxiNBt7Umxk3L1CgAVcaC0E=; b=YMMwnYSA/1pGh8DGw+U2LwIqkbhodwF8YW5xSWOEPDRMg1ZwfEoX7pOw7Q8cNQwtOr jR36t2SkjRkNcqkuxeqG2fK5LFSt76jn+wkkdbuabyaiFKpao4oycxOcMdsI5+NsucfF D33GashZPONPmLFRK8cI8K8LogqmojhTHtZIKHkxAQLgG6svJgzofwRbkVn9ZFH9/nMi /iybv2Dh/cw1P1xDNu8mSYSuZMS0QD4R6VybwhDfmk0EtubIFUet+CrnWpW1wUiG5gLM vrdz45Kh/j/0LIsycfBge71fV6amR2GK7RbRvyY/DSMDMY0Yx0x8e4a5Kyw0Jw7yFhiY GzkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dy312iFB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9si4207934ejo.46.2019.11.08.11.11.46; Fri, 08 Nov 2019 11:12:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dy312iFB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391992AbfKHTLM (ORCPT + 99 others); Fri, 8 Nov 2019 14:11:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:43570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391983AbfKHTLK (ORCPT ); Fri, 8 Nov 2019 14:11:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAA84206A3; Fri, 8 Nov 2019 19:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573240270; bh=5U2KoR/x+eZQqF9wvUyyyqcjxdn5SHVLosdDW4FvFbY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dy312iFB/fa6jc9z1YmCokJJnjmFZnHwHmoCxwsBgyM16X+Z2SdzUV7mC95U01pm0 zUI3w++fBxlegjRIo6HZx/o5GN8hzL68eOj8480oyC2Ac4wrGe6qUSSYRFefEZjTnJ p3E8LonyJc7ckZiENd2NVUg40G9hYv7sYa+dZyro= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vivien Didelot , Florian Fainelli , "David S. Miller" Subject: [PATCH 5.3 123/140] net: dsa: fix switch tree list Date: Fri, 8 Nov 2019 19:50:51 +0100 Message-Id: <20191108174912.478465365@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191108174900.189064908@linuxfoundation.org> References: <20191108174900.189064908@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot [ Upstream commit 50c7d2ba9de20f60a2d527ad6928209ef67e4cdd ] If there are multiple switch trees on the device, only the last one will be listed, because the arguments of list_add_tail are swapped. Fixes: 83c0afaec7b7 ("net: dsa: Add new binding implementation") Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/dsa/dsa2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -46,7 +46,7 @@ static struct dsa_switch_tree *dsa_tree_ dst->index = index; INIT_LIST_HEAD(&dst->list); - list_add_tail(&dsa_tree_list, &dst->list); + list_add_tail(&dst->list, &dsa_tree_list); kref_init(&dst->refcount);