Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2920343ybx; Fri, 8 Nov 2019 11:17:04 -0800 (PST) X-Google-Smtp-Source: APXvYqy7fuhUqm+Us8YoZEyFqd2fq0gQS/olQzKyTx/ls1sl6JFg//m1x1Zpniep921qzaAEvrIL X-Received: by 2002:a17:906:7094:: with SMTP id b20mr10420608ejk.134.1573240623969; Fri, 08 Nov 2019 11:17:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573240623; cv=none; d=google.com; s=arc-20160816; b=wz3RvyufM1XY5k7CFXseHVa9pTzMxfiQRMrtqXAjBhJ1tzn3TapG9gmGKQgcPr8HJE JdwAg1GIYWTSqOD08Ysk+TwyH/TL0uifQVUNXhEt/92roCPJdT94EWtZP75aV5mARuao oGJNv531jbDrB7pmYK9mRp0Not8TlngIycCpHHWhK03c7WF6b5+DDzA6zpHieM4IllHP VeiS2RoR85aSw6vTgWXOOl7EUFw/IGcyyWAETE3HdPTo6SgAIIZmPXiYQ59n+pkLz6dg 95y/llZGuTD40sDI1AYiHNav31Opp4Ru8rQ6m0MXa1cNGjbU9g7nS6RcMTq22WUZ9H6F G6wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=V+n/IdGvnQY0re9G1hJjrkIi3JYg6n/9SWJhMyt6kao=; b=M2LcDw0NIpxmpiUuhc/FHmt3yroXR8xtJGPs8On9c35RPGyWSoJiopdeqNvr55EFa0 hIKzaclv3WsYQ3b2ooj3nP+clCSMIermtJYg0dF2C19nXAvpSWr/aifEqz1El4kGWOx8 MYer5lVQfOoNo5kfQf+w6q4k0j2ZDysWWYvWz8Ae4h9D3kKdY6rUPQsRFvr3zcodCgRT wlN82FHwR2VZsoYm1XJcnv4+8XQnODr18DZC+nSZTy0Ji3EpKJxtBXRB9qn89YYwFvO5 UoieI9sVVlOlIusQyvXVuGTagZpFlRtd4SWRO5+gdL2sreYGEOzC1zaiszs4wNU5B2xX W1oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=n6GSJrS9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v35si4751040edm.213.2019.11.08.11.16.40; Fri, 08 Nov 2019 11:17:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=n6GSJrS9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390809AbfKHTDi (ORCPT + 99 others); Fri, 8 Nov 2019 14:03:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:33256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390801AbfKHTDe (ORCPT ); Fri, 8 Nov 2019 14:03:34 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45DD62067B; Fri, 8 Nov 2019 19:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573239813; bh=ffIQ5dJGnYJzi9DjSzvkcNshyzB7rOklGtY+nCx3KnY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n6GSJrS979VgHpHq7LUbjvzpxLcvMwm9aAB5pmz5VC6a3dwrTZBsPnOmkaoMBXjrQ 0Rhc+1ORglvuZRGfrksomBQniF+nvh4j3Ddrri2l4yIZ2Tenvojunzw0RgWB/tpiVa 8sv+eDMf2SialQGdbK17zsrIcRgvQIF/z7zCtrOc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vivien Didelot , Florian Fainelli , "David S. Miller" Subject: [PATCH 4.19 69/79] net: dsa: fix switch tree list Date: Fri, 8 Nov 2019 19:50:49 +0100 Message-Id: <20191108174823.875664780@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191108174745.495640141@linuxfoundation.org> References: <20191108174745.495640141@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vivien Didelot [ Upstream commit 50c7d2ba9de20f60a2d527ad6928209ef67e4cdd ] If there are multiple switch trees on the device, only the last one will be listed, because the arguments of list_add_tail are swapped. Fixes: 83c0afaec7b7 ("net: dsa: Add new binding implementation") Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/dsa/dsa2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -49,7 +49,7 @@ static struct dsa_switch_tree *dsa_tree_ dst->index = index; INIT_LIST_HEAD(&dst->list); - list_add_tail(&dsa_tree_list, &dst->list); + list_add_tail(&dst->list, &dsa_tree_list); kref_init(&dst->refcount);