Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161275AbWALVGE (ORCPT ); Thu, 12 Jan 2006 16:06:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161274AbWALVGB (ORCPT ); Thu, 12 Jan 2006 16:06:01 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:16606 "EHLO palinux.hppa") by vger.kernel.org with ESMTP id S932703AbWALVF7 (ORCPT ); Thu, 12 Jan 2006 16:05:59 -0500 Date: Thu, 12 Jan 2006 14:05:59 -0700 From: Matthew Wilcox To: Daniel Drake Cc: Jon Mason , mulix@mulix.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: pcnet32 devices with incorrect trident vendor ID Message-ID: <20060112210559.GL19769@parisc-linux.org> References: <20060112175051.GA17539@us.ibm.com> <43C6C0E6.7030705@gentoo.org> <20060112205714.GK19769@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060112205714.GK19769@parisc-linux.org> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 37 On Thu, Jan 12, 2006 at 01:57:14PM -0700, Matthew Wilcox wrote: > On Thu, Jan 12, 2006 at 08:49:42PM +0000, Daniel Drake wrote: > > interesting: > > > > http://forums.gentoo.org/viewtopic-t-420013-highlight-trident.html > > > > The user saw the correct vendor ID (AMD) in 2.4, but when upgrading to > > 2.6, it changed to Trident. > > It looks to me like there used to be a quirk that knew about this bug > and fixed it. > > The reason I say this is that the lspci -x dumps are the same -- both > featuring the wrong vendor ID. Want to dig through 2.4 and look for > this quirk? Oh -- found it. It's still in 2.6: static void fixup_broken_pcnet32(struct pci_dev* dev) { if ((dev->class>>8 == PCI_CLASS_NETWORK_ETHERNET)) { dev->vendor = PCI_VENDOR_ID_AMD; pci_write_config_word(dev, PCI_VENDOR_ID, PCI_VENDOR_ID_AMD); } } DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TRIDENT, PCI_ANY_ID, fixup_broken_pcnet32); Wonder why it isn't working now ... someone with a PPC box needs to check (a) whether this function is being called and (b) if it is called, why it's not doing what it's supposed to. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/